Merge back 'chore_release-8.5.0' into 'chore_release-pd-8.5.0' #18638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it looks like there are conflicting changes in |
Labware labels are passed through from the protocol api all the way to the commands and eventually the client with little actual _functionality_ dependent on their types or their values. That means that the only thing that checks them is pydantic model validation, and if you avoid that - as the legacy command mapper does by using model_construct() - then other downstream things won't be happy. In this case, OT-2 LPC starts its session by echoing commands it reads from the robot analysis back out to a maintenance run. When a client uses HTTP to create commands, pydantic model validation _does_ run, and it would fail, and this wasn't an anticipated error scenario because, well, it's echoed from the protocol! But the incorrect data made it through. Another way to handle this would be to do pydantic model validation on the protocol inputs, but that would break any old protocols that implicitly depended on this working. Compatibility! Also IMO it's silly that we enforce this if the entire system works just fine if you give it an integer. Closes RESC-423
ddcc4
added a commit
that referenced
this pull request
Jun 16, 2025
ddcc4
added a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in @smb2268's labware changes.