Skip to content

refactor(app): make locationDetails digestible by Mixpanel for LPC analytics #18649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jun 16, 2025

Closes EXEC-1621

Overview

Product has decided they do want to more granularly analyze the location sequence that we provide whenever offsets are saved, but currently, Mixpanel just stringifies the location sequence array. By providing the location sequence as a nested object, the location sequence should be digestible by Mixpanel.

Test Plan and Hands on Testing

  • Ran a few LPCs and inspected the output of the mixpanel event.

Risk assessment

none, just changes the shape of an analytic event

@mjhuff mjhuff requested a review from a team as a code owner June 16, 2025 19:00
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader June 16, 2025 19:00
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey whatever works

@mjhuff mjhuff changed the base branch from edge to chore_release-8.5.0 June 16, 2025 19:20
@mjhuff mjhuff requested review from a team as code owners June 16, 2025 19:20
@mjhuff mjhuff force-pushed the app_lpc-analytics branch from d14b9c6 to 0ea8288 Compare June 16, 2025 19:20
@mjhuff mjhuff removed request for a team June 16, 2025 19:23
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 24.12%. Comparing base (f18d929) to head (0ea8288).
Report is 1 commits behind head on chore_release-8.5.0.

Files with missing lines Patch % Lines
...s/LabwarePositionCheck/LPCFlows/useLPCAnalytics.ts 0.00% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-8.5.0   #18649       +/-   ##
========================================================
- Coverage                55.54%   24.12%   -31.43%     
========================================================
  Files                     3218     3218               
  Lines                   277823   277833       +10     
  Branches                 28308    28277       -31     
========================================================
- Hits                    154318    67022    -87296     
- Misses                  123319   210793    +87474     
+ Partials                   186       18      -168     
Flag Coverage Δ
app 2.03% <0.00%> (-45.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/LabwarePositionCheck/LPCFlows/useLPCAnalytics.ts 0.00% <0.00%> (-1.67%) ⬇️

... and 1624 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff merged commit ce0a12e into chore_release-8.5.0 Jun 16, 2025
16 checks passed
@mjhuff mjhuff deleted the app_lpc-analytics branch June 16, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants