feat(app): add disposal volume #18652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add disposal volume close AUTH-
add Disposal volume to QT dispense close AUTH-1980
jerader
reviewed
Jun 17, 2025
app/src/organisms/ODD/QuickTransferFlow/Aspirate/hooks/useAspirateSettingsConfig.ts
Outdated
Show resolved
Hide resolved
jerader
reviewed
Jun 17, 2025
app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/DisposalVolume.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Jun 17, 2025
Comment on lines
+104
to
+111
| let pipetteName = state.pipette.model | ||
| if (state.pipette.channels === 1) { | ||
| pipetteName = pipetteName + `_single_flex` | ||
| } else if (state.pipette.channels === 8) { | ||
| pipetteName = pipetteName + `_multi_flex` | ||
| } else { | ||
| pipetteName = pipetteName + `_96` | ||
| } |
There was a problem hiding this comment.
huh, do we not have a util that gets the pipette name from the model? like maybe you can use getPipetteSpecsV2() to get the pipette specs then you can use the specs to get the right info? i just think appending strings like this is a bit brittle
There was a problem hiding this comment.
state.pipette.model is like p50 and it's not PipetteModel so cannot use getPipetteSpecsV2()
There was a problem hiding this comment.
this is fine for now then.
jerader
reviewed
Jun 17, 2025
| <InputField | ||
| type="text" | ||
| value={String(volume ?? '')} | ||
| title={t('disposal_volume_µL')} |
There was a problem hiding this comment.
i didn't know you can use the µ symbol for an i18n string, nice
There was a problem hiding this comment.
i took this from the same json and it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add Disposal volume to QT dispense
close AUTH-1980
Test Plan and Hands on Testing
multiDispenseChangelog
Review requests
Risk assessment
low