refactor(protocol-designer): remove enableLiquidClasses feature flag

[ncdiehl11]

Overview

This PR removes enableLiquidClasses feature flag in PD.

Closes AUTH-1938

Test Plan and Hands on Testing

smoke test

Changelog

• remove enableLiquidClasses ff from application and deprecate ff
• fix tests

Review requests

--

Risk assessment

low

[jerader]

wowza

[codecov]

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 23.83%. Comparing base (b19784c) to head (d50e9ef).
Report is 2 commits behind head on chore_release-pd-8.5.0.

Files with missing lines	Patch %	Lines
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx	0.00%	6 Missing ⚠️
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx	0.00%	5 Missing ⚠️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx	0.00%	3 Missing ⚠️
...onents/organisms/AssignLiquidsModal/LiquidCard.tsx	0.00%	1 Missing ⚠️
.../components/organisms/DefineLiquidsModal/index.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18662      +/-   ##
==========================================================
- Coverage                   24.12%   23.83%   -0.29%     
==========================================================
  Files                        3282     3282              
  Lines                      285236   285174      -62     
  Branches                    28696    28672      -24     
==========================================================
- Hits                        68808    67971     -837     
- Misses                     216403   217178     +775     
  Partials                       25       25              

Files with missing lines	Coverage Δ
protocol-designer/src/feature-flags/reducers.ts	57.37% <ø> (-1.36%)	⬇️
protocol-designer/src/feature-flags/selectors.ts	88.33% <ø> (-0.73%)	⬇️
protocol-designer/src/feature-flags/types.ts	100.00% <100.00%> (ø)
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx	18.83% <ø> (-9.88%)	⬇️
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx	69.56% <100.00%> (-5.14%)	⬇️
...r/src/pages/ProtocolOverview/LiquidDefinitions.tsx	79.74% <100.00%> (-0.98%)	⬇️
...onents/organisms/AssignLiquidsModal/LiquidCard.tsx	1.01% <0.00%> (+<0.01%)	⬆️
.../components/organisms/DefineLiquidsModal/index.tsx	2.96% <0.00%> (+0.01%)	⬆️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx	4.45% <0.00%> (+0.02%)	⬆️
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx	0.77% <0.00%> (+0.01%)	⬆️
... and 1 more

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[koji]

🚀

[ncdiehl11]

Note that a few lines in the mixSettings Cypress test are commented. I will work with @alexjoel42 to reimplement them in a fast followup. (Issue stemming from finding all checkboxes on the same DOM element ID).

For assurance, I tested in practice with the same testing fixture used in mixSettings, and all works well.