Skip to content

fix(components): Fix typo in dropdown menu #18665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jun 17, 2025

Overview

Fix typo in dropdown menu to resolve warning in dev tools console

Screenshot 2025-06-17 at 5 49 54 PM

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review June 17, 2025 21:22
@koji koji requested review from a team as code owners June 17, 2025 21:22
@koji koji requested review from TamarZanzouri and removed request for a team June 17, 2025 21:22
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.90%. Comparing base (3d6e564) to head (fca5544).
Report is 2 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18665      +/-   ##
==========================================================
- Coverage                   24.11%   23.90%   -0.22%     
==========================================================
  Files                        3282     3282              
  Lines                      285117   285288     +171     
  Branches                    28694    28742      +48     
==========================================================
- Hits                        68766    68208     -558     
- Misses                     216326   217055     +729     
  Partials                       25       25              
Flag Coverage Δ
protocol-designer 19.17% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/molecules/DropdownMenu/index.tsx 86.04% <100.00%> (-3.20%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested review from ncdiehl11 and jerader and removed request for TamarZanzouri June 17, 2025 21:50
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@koji koji merged commit 851ff53 into chore_release-pd-8.5.0 Jun 18, 2025
70 checks passed
@koji koji deleted the fix_type-in-dropdown-menu branch June 18, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants