Skip to content

feat(docs): unify CSS for multiple mkdocs projects #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

ecormany
Copy link
Contributor

@ecormany ecormany commented Jun 18, 2025

Overview

Adding a lil plugin so we can share one CSS file between multiple publications. You'd think this would work out of the box, but it totally doesn't!

Test Plan and Hands on Testing

tested locally, will see if this works in CI
it does!

Changelog

  • vibecoded a new plugin
  • moved opentrons-theme.css up
  • added the new plugin to Flex and Stacker docs yml
  • pointed to the new css location
  • added the plugin as editable load in uv setup

Review requests

  • where does this fit on the spectrum of kludge to elegant?
  • whomst should we list as plugin author?

Risk assessment

low. plugin code created from whole cloth by gemini but looks very straightforward.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple improvements to make for readability, consistency, and reliability

@ecormany ecormany force-pushed the docs-stacker-manual branch from b831393 to b38beb8 Compare June 18, 2025 17:41
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (981511a) to head (cc711dc).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18670   +/-   ##
=======================================
  Coverage   24.75%   24.75%           
=======================================
  Files        3284     3284           
  Lines      285464   285416   -48     
  Branches    28663    28655    -8     
=======================================
  Hits        70662    70662           
+ Misses     214781   214733   -48     
  Partials       21       21           
Flag Coverage Δ
protocol-designer 19.04% <ø> (+<0.01%) ⬆️
step-generation 5.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ecormany ecormany requested a review from sfoster1 June 18, 2025 18:41
@ecormany ecormany changed the base branch from docs-stacker-manual to edge June 21, 2025 02:26
@ecormany ecormany marked this pull request as ready for review June 21, 2025 02:26
@ecormany ecormany requested review from a team as code owners June 21, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants