Skip to content

refactor(step-generation): remove version number from load labware & … #18671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 18, 2025

…adapter

Overview

This is a temporary fix that addresses the issue where the labware definitions are missing the inner well geometry. When the version number is removed, i believe PE automatically uses the latest labware definition version.

In a follow up post-8.5.0 release, we should refactor PD to migrate labwares to the latest versions when importing an older protocol: here is the ticket to address that.

Test Plan and Hands on Testing

Review code. i already smoke tested but you can smoke test as well 😄

Changelog

  • temp comment out the version numbers and fix tests

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 18, 2025 13:33
@jerader jerader requested a review from ddcc4 June 18, 2025 13:33
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.04%. Comparing base (851ff53) to head (27c0e39).
Report is 3 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18671      +/-   ##
==========================================================
+ Coverage                   23.83%   24.04%   +0.20%     
==========================================================
  Files                        3282     3256      -26     
  Lines                      285228   281522    -3706     
  Branches                    28688    28562     -126     
==========================================================
- Hits                        67992    67690     -302     
+ Misses                     217211   213807    -3404     
  Partials                       25       25              
Flag Coverage Δ
protocol-designer 19.11% <50.00%> (-0.01%) ⬇️
step-generation 5.18% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
step-generation/src/utils/pythonFileUtils.ts 88.29% <100.00%> (-0.06%) ⬇️

... and 133 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit b6b4f20 into chore_release-pd-8.5.0 Jun 18, 2025
18 checks passed
@jerader jerader deleted the sg_remove-load-command-version branch June 18, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants