refactor(api,hardware-testing): Make the ExecutionManager optional in the AbstractModule class to build stand-alone modules. #18677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the AbstractModule class to build stand-alone modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A few small changes to make building modules stand-alone (Outside of the OT3Controller) a bit easier for creating test scripts.
Test Plan and Hands on Testing
Changelog
ExecutionManageroptional in the AbstractModule class to build stand-alone modules.build_standaloneand usebuildwith optionalexecution_managerinstead.wait_for_is_runningfrom theAbsorbanceReadermodule, since the base class already has this.Review requests
Risk assessment
Low, changes make hardware testing easier.