Skip to content

Merge back 'chore_release-pd-8.5.0' into 'edge' #18679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025
Merged

Conversation

ddcc4
Copy link
Contributor

@ddcc4 ddcc4 commented Jun 18, 2025

Merge all our changes today into edge before the holiday.

koji and others added 4 commits June 18, 2025 08:48
* fix(components): Fix typo in dropdown menu
#18662)

This PR removes `enableLiquidClasses` feature flag in PD.

Closes AUTH-1938
…nAndReferenceVolumes (#18666)

Updates `step-generation` util `getTransferPlanAndReferenceVolumes` to
return most accurate reference volumes for aspirate and dispense
properties.
#18671)

…adapter

This is a temporary fix that addresses the issue where the labware
definitions are missing the inner well geometry when using API version 2.24. When the version number
is removed, i believe PE automatically uses the latest labware
definition version.
@ddcc4 ddcc4 requested review from koji, ncdiehl11 and jerader June 18, 2025 18:29
@ddcc4 ddcc4 requested review from a team as code owners June 18, 2025 18:29
This PR adds copy for 8.5.0 migration modal and wires it up. It also
updates the copy for import confirmation from "Confirm" to "Import", and
updates tests accordingly.

Closes AUTH-1975
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 74.41860% with 33 lines in your changes missing coverage. Please review.

Project coverage is 24.11%. Comparing base (b19784c) to head (cedd97d).
Report is 74 commits behind head on edge.

Files with missing lines Patch % Lines
...onents/organisms/FileUploadMessagesModal/index.tsx 50.00% 6 Missing ⚠️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.00% 6 Missing ⚠️
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx 0.00% 5 Missing ⚠️
...ocolSteps/StepForm/PipetteFields/FlowRateField.tsx 0.00% 4 Missing ⚠️
protocol-designer/src/load-file/migration/8_5_0.ts 0.00% 3 Missing ⚠️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx 0.00% 3 Missing ⚠️
...r/src/steplist/formLevel/handleFormChange/utils.ts 0.00% 3 Missing ⚠️
...onents/organisms/AssignLiquidsModal/LiquidCard.tsx 0.00% 1 Missing ⚠️
.../components/organisms/DefineLiquidsModal/index.tsx 0.00% 1 Missing ⚠️
...tocolSteps/StepForm/StepTools/PauseTools/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18679      +/-   ##
==========================================
- Coverage   24.12%   24.11%   -0.01%     
==========================================
  Files        3282     3284       +2     
  Lines      285236   285501     +265     
  Branches    28696    29080     +384     
==========================================
+ Hits        68808    68850      +42     
- Misses     216403   216627     +224     
+ Partials       25       24       -1     
Flag Coverage Δ
app 0.33% <0.00%> (-0.01%) ⬇️
protocol-designer 19.14% <52.71%> (-0.11%) ⬇️
step-generation 5.26% <45.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% <ø> (ø)
components/src/molecules/DropdownMenu/index.tsx 88.37% <100.00%> (-0.88%) ⬇️
...onents/organisms/FileUploadMessagesModal/utils.tsx 76.85% <100.00%> (+3.09%) ⬆️
...ner/src/components/organisms/StepSummary/index.tsx 26.97% <100.00%> (ø)
protocol-designer/src/feature-flags/reducers.ts 57.37% <ø> (-1.36%) ⬇️
protocol-designer/src/feature-flags/selectors.ts 88.33% <ø> (-0.73%) ⬇️
protocol-designer/src/feature-flags/types.ts 100.00% <100.00%> (ø)
protocol-designer/src/form-types.ts 46.29% <ø> (ø)
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 26.17% <100.00%> (-2.54%) ⬇️
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 80.00% <100.00%> (+5.30%) ⬆️
... and 24 more

... and 81 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jerader and others added 2 commits June 18, 2025 15:51
Remove references to deprecated moveLiquid form fields:
- `aspirate_delay_mmFromBottom`
- `dispense_delay_mmFromBottom`
- `blowout_z_offset`

These fields are addressed by submerge/retract properties in PD 8.5.0.

Closes AUTH-1977
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddcc4 ddcc4 merged commit 0aeacc6 into edge Jun 18, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants