Skip to content

fix(protocol-designer): update logic for blowout UI max flow rate #18684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 18, 2025

Overview

For calculating blowout pipette max flow rate (µl/s), the hardware controller specifies the following rather than using the pipette definition's dispense curve:

maxFlowRate = shaftULperMM * maxPlungerSpeed

Test Plan and Hands on Testing

not much to test. I confirmed the correct behavior with Andy and smoke tested a few easy cases

Changelog

Review requests

Risk assessment

low. affects only UI recommended flow rate

use hardware controller logic for blowout max flow rate
@ncdiehl11 ncdiehl11 self-assigned this Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.87%. Comparing base (cedd97d) to head (987af93).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
...ocolSteps/StepForm/PipetteFields/FlowRateField.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18684      +/-   ##
==========================================================
- Coverage                   24.11%   23.87%   -0.24%     
==========================================================
  Files                        3284     3284              
  Lines                      285501   285497       -4     
  Branches                    29080    29075       -5     
==========================================================
- Hits                        68850    68176     -674     
- Misses                     216627   217297     +670     
  Partials                       24       24              
Flag Coverage Δ
protocol-designer 19.05% <92.85%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gner/ProtocolSteps/StepForm/PipetteFields/utils.ts 18.96% <100.00%> (ø)
...ocolSteps/StepForm/PipetteFields/FlowRateField.tsx 1.05% <0.00%> (-0.01%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 19, 2025 02:26
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 19, 2025 02:26
@ncdiehl11 ncdiehl11 requested review from andySigler and jerader and removed request for a team June 19, 2025 13:36
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jerader jerader merged commit d4b4804 into chore_release-pd-8.5.0 Jun 20, 2025
16 checks passed
@jerader jerader deleted the pd_fix-uimaxflowrate-blowout branch June 20, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants