Skip to content

docs(api): PD interop changes in 8.5; new params #18686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: chore_release-8.5.0
Choose a base branch
from

Conversation

emilyburghardt
Copy link
Collaborator

@emilyburghardt emilyburghardt commented Jun 19, 2025

Overview

Updates to the Liquid Control page for PD interop + new params added.

Test Plan and Hands on Testing

sandbox: http://sandbox.docs.opentrons.com/docs-pd-interop-8.5/v2/

Changelog

-added description for flow_rate param in aspirate/dispense commands (and contrast with rate). checked the API reference entries.

  • added description for air gap in_place and flow_rate parameters (and contrast with rate)
  • added description for mm_from_edge behavior and warning.

Review requests

Need to confirm the warning for mm_from_edge in touch tip.

Risk assessment

low.

@ecormany ecormany added docs papi-v2 Python API V2 labels Jun 21, 2025
…entrons into docs-pd-interop-8.5

setting tracking to chore_release-8.5.0 for this docs branch.
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.22%. Comparing base (ec54caf) to head (26a6d9c).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-8.5.0   #18686   +/-   ##
====================================================
  Coverage                24.22%   24.22%           
====================================================
  Files                     3258     3258           
  Lines                   281743   281743           
  Branches                 29429    29429           
====================================================
  Hits                     68247    68247           
  Misses                  213474   213474           
  Partials                    22       22           
Flag Coverage Δ
protocol-designer 18.70% <ø> (ø)
step-generation 4.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers what it needs to! Just a few suggestions for readability.

@@ -312,7 +312,7 @@ This example uses the current well and sets the speed to 80 mm/s::
Mix
====

The :py:meth:`~.InstrumentContext.mix` method aspirates and dispenses repeatedly in a single location. It's designed to mix the contents of a well together using a single command rather than using multiple ``aspirate()`` and ``dispense()`` calls. This method includes arguments that let you specify the number of times to mix, the volume (in µL) of liquid, and the well that contains the liquid you want to mix.
The :py:meth:`~.InstrumentContext.mix` method aspirates and dispenses repeatedly in a single location. It's designed to mix the contents of a well together using a single command rather than using multiple ``aspirate()`` and ``dispense()`` calls. This method includes arguments that let you specify the number of times to mix, the volume (in µL) of liquid, and the well that contains the liquid you want to mix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spurious change, and better to not have trailing whitespace.

Comment on lines +573 to +575
:param aspirate_flow_rate: The absolute flow rate for each aspirate in the mix, in µL/s.
If this is specified, ``rate`` must not be set.
:param dispense_flow_rate: The flow rate for each dispense in the mix, in µL/s.
:param dispense_flow_rate: The absolute flow rate for each dispense in the mix, in µL/s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly needed, "in µL/s" is clear enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I changed this only to match the aspirate() and dispense() entries; I checked those first.

@emilyburghardt emilyburghardt marked this pull request as ready for review June 23, 2025 20:54
@emilyburghardt emilyburghardt requested a review from a team as a code owner June 23, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants