-
Notifications
You must be signed in to change notification settings - Fork 183
docs(api): PD interop changes in 8.5; new params #18686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…entrons into docs-pd-interop-8.5 setting tracking to chore_release-8.5.0 for this docs branch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.5.0 #18686 +/- ##
========================================================
- Coverage 54.64% 24.22% -30.43%
========================================================
Files 3258 3258
Lines 281788 281757 -31
Branches 29494 29429 -65
========================================================
- Hits 153995 68244 -85751
- Misses 127603 213491 +85888
+ Partials 190 22 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covers what it needs to! Just a few suggestions for readability.
…entrons into docs-pd-interop-8.5 getting latest
…entrons into docs-pd-interop-8.5 merge to chore release branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make some further improvements to the air_gap()
docstring, but this is good to go for now. 🚢
Overview
Updates to the Liquid Control page for PD interop + new params added.
Test Plan and Hands on Testing
sandbox: http://sandbox.docs.opentrons.com/docs-pd-interop-8.5/v2/
Changelog
-added description for
flow_rate
param in aspirate/dispense commands (and contrast withrate
). checked the API reference entries.in_place
andflow_rate
parameters (and contrast withrate
)mm_from_edge
behavior and warning.Review requests
Need to confirm the warning for
mm_from_edge
in touch tip.Risk assessment
low.