Skip to content

fix(protocol-designer): default reference fields to well-bottom or well-top #18690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 20, 2025

closes RQA-4300

Overview

Alex's ot-2 gut-check protocol failed analysis because the reference fields were all null. looking at the form, it makes sense to default those fields to well-bottom for aspirate/dispense position and well-top for retract & submerge positions in the presaved forms. i also fixed a small bug where we were incorrectly typing the value even though it was technically unknown.

Test Plan and Hands on Testing

upload the attached protocol (from the comment in the ticket) into the app. should pass analysis now since the position fields are not None

Changelog

  • change default values for the reference fields to well-bottom or well-top - the liquid classes for Flex should update them correctly still, this is just the default values.
  • fix a bug with the value in the modal

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 20, 2025 12:13
@jerader jerader requested a review from ddcc4 June 20, 2025 12:13
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.88%. Comparing base (d4b4804) to head (2e8fd92).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
...rc/components/organisms/TipPositionModal/hooks.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.5.0   #18690   +/-   ##
=======================================================
  Coverage                   23.87%   23.88%           
=======================================================
  Files                        3284     3284           
  Lines                      285497   285497           
  Branches                    29075    29075           
=======================================================
+ Hits                        68176    68177    +1     
+ Misses                     217297   217296    -1     
  Partials                       24       24           
Flag Coverage Δ
protocol-designer 19.05% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/components/organisms/TipPositionModal/index.tsx 77.27% <100.00%> (ø)
...src/step-forms/test/createPresavedStepForm.test.ts 96.46% <100.00%> (ø)
...r/src/steplist/formLevel/getDefaultsForStepType.ts 89.86% <100.00%> (ø)
...list/formLevel/test/getDefaultsForStepType.test.ts 97.79% <100.00%> (ø)
...rc/components/organisms/TipPositionModal/hooks.tsx 39.78% <66.66%> (+0.65%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader requested a review from koji June 20, 2025 13:24
@jerader jerader merged commit 35cb888 into chore_release-pd-8.5.0 Jun 20, 2025
16 checks passed
@jerader jerader deleted the pd_default-reference-fields branch June 20, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants