fix(protocol-designer): default reference fields to well-bottom or well-top #18690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-4300
Overview
Alex's ot-2 gut-check protocol failed analysis because the reference fields were all
null
. looking at the form, it makes sense to default those fields towell-bottom
for aspirate/dispense position andwell-top
for retract & submerge positions in the presaved forms. i also fixed a small bug where we were incorrectly typing the value even though it was technicallyunknown
.Test Plan and Hands on Testing
upload the attached protocol (from the comment in the ticket) into the app. should pass analysis now since the position fields are not
None
Changelog
well-bottom
orwell-top
- the liquid classes for Flex should update them correctly still, this is just the default values.Risk assessment
low