fix(api): Fix gripper move point calculation for modules #18691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-4295
Overview
When we
get_labware_origin_position
, we start by retrieving the deck coordinates for the underlying addressable area, so for example, if the addressable area isheaterShakerV1D1
, we get the coordinates forD1
. Much later down stream, if there is a module involved in a stackup, we offsetD1
by theheaterShakerV1D1
'soffsetFromCutoutFixture
.In #18564, we refactored
get_labware_grip_point
to utilize more of theget_labware_origin_position
logic (see that PR for more details), however, the grip point does exactly one thing different: we utilize the deck position for the actual addressable area we care about, ex,heaterShakerV1D1
. This means that an extraoffsetFromCutoutFixture
is applied for grip moves.To fix, we should refactor
get_labware_origin_position
to get the deck coordinates for the addressable area we actually care about and not do theoffsetFromCutoutFixture
adjustment much later down stream. Doing so unifies the gripper point and labware point calculation behavior almost entirely.a89db22 fixes the second half of the issue, which is we weren't correctly applying all stacking offsets in a stackup to the gripper moves. Now we are.
Test Plan and Hands on Testing
Changelog
Risk assessment
lowish - the risk only comes from the
get_grip_point
changes, since we have regression testing for the labware origin changes.