-
Notifications
You must be signed in to change notification settings - Fork 183
feature(app,protocol-designer): Remove aa from deck config #18692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(app,protocol-designer): Remove aa from deck config #18692
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18692 +/- ##
==========================================
+ Coverage 24.75% 28.12% +3.36%
==========================================
Files 3284 3227 -57
Lines 285446 252607 -32839
Branches 28649 25652 -2997
==========================================
+ Hits 70657 71036 +379
+ Misses 214768 181551 -33217
+ Partials 21 20 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock, but let's get rid of some typos and extra console logs before merging
@@ -200,7 +200,7 @@ export const getFixtureOptions = ( | |||
addressableAreaId: AddressableAreaNamesWithFakes | |||
): CutoutConfigMap[][] => { | |||
let availableOptions: CutoutConfigMap[][] = [] | |||
const TrashBinAA = getAddressableAreaMatchForAreaId( | |||
const TrashBinAA = replaceAAWithFakeAA( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AA
means addressable area?
Overview
closes https://opentrons.atlassian.net/browse/EXEC-1622.
Remove aa from deck config.
Bug fixes when adding a waste chute fixture and a module fixture.
Test Plan and Hands on Testing
Changelog
add AA to remove logic and caluclate fixture to replace with
Review requests
changes make sense?
Risk assessment
Medium. need to smoke test deck config and to make sure we are able to remove fixtures