Skip to content

feature(app,protocol-designer): Remove aa from deck config #18692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 24, 2025

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Jun 20, 2025

Overview

closes https://opentrons.atlassian.net/browse/EXEC-1622.
Remove aa from deck config.
Bug fixes when adding a waste chute fixture and a module fixture.

Test Plan and Hands on Testing

  1. Add combo fixtures to deck config and make sure you can remove aa from deck config
  2. Add simple fixtures and make sure you are able to remove them
  3. Add staging area and make sure you are able to remove it.

Changelog

add AA to remove logic and caluclate fixture to replace with

Review requests

changes make sense?

Risk assessment

Medium. need to smoke test deck config and to make sure we are able to remove fixtures

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 44.02516% with 178 lines in your changes missing coverage. Please review.

Project coverage is 28.12%. Comparing base (e161ab1) to head (15e6aa4).
Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
shared-data/js/fixtures.ts 60.00% 86 Missing ⚠️
...ware-sim/DeckConfigurator/WasteChuteConfigItem.tsx 0.00% 10 Missing ⚠️
...uration/hooks/useDeckConfigurationEditingTools.tsx 0.00% 9 Missing ⚠️
...ware-sim/DeckConfigurator/AbsorbanceReaderItem.tsx 0.00% 8 Missing ⚠️
.../hardware-sim/DeckConfigurator/FlexStackerItem.tsx 0.00% 8 Missing ⚠️
...are-sim/DeckConfigurator/StagingAreaConfigItem.tsx 0.00% 8 Missing ⚠️
...are-sim/DeckConfigurator/TemperatureModuleItem.tsx 0.00% 8 Missing ⚠️
...onents/src/hardware-sim/DeckConfigurator/index.tsx 0.00% 8 Missing ⚠️
...hardware-sim/DeckConfigurator/HeaterShakerItem.tsx 0.00% 7 Missing ⚠️
...ardware-sim/DeckConfigurator/MagneticBlockItem.tsx 0.00% 7 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18692      +/-   ##
==========================================
+ Coverage   24.75%   28.12%   +3.36%     
==========================================
  Files        3284     3227      -57     
  Lines      285446   252607   -32839     
  Branches    28649    25652    -2997     
==========================================
+ Hits        70657    71036     +379     
+ Misses     214768   181551   -33217     
+ Partials       21       20       -1     
Flag Coverage Δ
components 4.66% <20.12%> (+0.09%) ⬆️
labware-library 3.98% <20.12%> (+<0.01%) ⬆️
opentrons-ai-client 3.20% <20.12%> (+0.02%) ⬆️
protocol-designer 19.04% <20.12%> (+<0.01%) ⬆️
shared-data 2.59% <44.02%> (-69.89%) ⬇️
step-generation 5.27% <20.12%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/constants.ts 100.00% <100.00%> (ø)
.../organisms/DeviceDetailsDeckConfiguration/utils.ts 0.00% <0.00%> (ø)
...hardware-sim/DeckConfigurator/HeaterShakerItem.tsx 3.70% <0.00%> (ø)
...ardware-sim/DeckConfigurator/MagneticBlockItem.tsx 3.63% <0.00%> (ø)
...hardware-sim/DeckConfigurator/ThermocyclerItem.tsx 4.25% <0.00%> (ø)
...rdware-sim/DeckConfigurator/TrashBinConfigItem.tsx 3.57% <0.00%> (ø)
...ware-sim/DeckConfigurator/AbsorbanceReaderItem.tsx 4.08% <0.00%> (ø)
.../hardware-sim/DeckConfigurator/FlexStackerItem.tsx 3.57% <0.00%> (+0.06%) ⬆️
...are-sim/DeckConfigurator/StagingAreaConfigItem.tsx 3.70% <0.00%> (+0.06%) ⬆️
...are-sim/DeckConfigurator/TemperatureModuleItem.tsx 3.57% <0.00%> (ø)
... and 4 more

... and 1632 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TamarZanzouri TamarZanzouri changed the title Exec 1622 refactor remove fixture to accept an aa feature(app, PD); Jun 23, 2025
@TamarZanzouri TamarZanzouri changed the title feature(app, PD); feature(app, PD): Remove aa from deck config Jun 23, 2025
@TamarZanzouri TamarZanzouri marked this pull request as ready for review June 23, 2025 13:52
@TamarZanzouri TamarZanzouri requested review from a team as code owners June 23, 2025 13:52
@TamarZanzouri TamarZanzouri requested review from ncdiehl11 and sfoster1 and removed request for a team and ncdiehl11 June 23, 2025 13:52
@sfoster1 sfoster1 changed the title feature(app, PD): Remove aa from deck config feature(app,protocol-designer): Remove aa from deck config Jun 23, 2025
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock, but let's get rid of some typos and extra console logs before merging

@@ -200,7 +200,7 @@ export const getFixtureOptions = (
addressableAreaId: AddressableAreaNamesWithFakes
): CutoutConfigMap[][] => {
let availableOptions: CutoutConfigMap[][] = []
const TrashBinAA = getAddressableAreaMatchForAreaId(
const TrashBinAA = replaceAAWithFakeAA(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AA means addressable area?

@TamarZanzouri TamarZanzouri merged commit 144df01 into edge Jun 24, 2025
61 checks passed
@TamarZanzouri TamarZanzouri deleted the EXEC-1622-refactor-remove-fixture-to-accept-an-aa branch June 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants