-
Notifications
You must be signed in to change notification settings - Fork 183
feat(shared-data): add stacking offsets for well plates in Flex Stacker #18725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18725 +/- ##
===========================================
- Coverage 56.91% 24.77% -32.14%
===========================================
Files 3243 3284 +41
Lines 282323 286141 +3818
Branches 35451 29382 -6069
===========================================
- Hits 160680 70891 -89789
- Misses 121440 215229 +93789
+ Partials 203 21 -182
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missed a few files
shared-data/labware/definitions/2/corning_48_wellplate_1.6ml_flat/2.json
Outdated
Show resolved
Hide resolved
shared-data/labware/definitions/2/corning_96_wellplate_360ul_flat/2.json
Outdated
Show resolved
Hide resolved
shared-data/labware/definitions/2/opentrons_96_wellplate_200ul_pcr_full_skirt/2.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested for the Pipfile thing, and for labware version bumps (which are already being worked on in #18726.)
…and gate for stacker compatible labware. (#18726)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good once tests pass! Just holding approval for the Pipfile/Pipfile.lock thing above. I don't think either of those files need to be modified here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PD CI test is weird, it's passing locally but failing on CI. I spoke with @jerader and this should be fine to merge in. |
@SyntaxColoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
Overview
Add stacking offsets for well plates to improve Flex Stacker storage alignment
Test Plan and Hands on Testing
Tested offsets with protocol:
hardware-testing/hardware_testing/protocols/labware_stack_offset_test.py
Changelog
Review requests
Risk assessment