Skip to content

feat(shared-data): add stacking offsets for well plates in Flex Stacker #18725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 27, 2025

Conversation

rclarke0
Copy link
Contributor

Overview

Add stacking offsets for well plates to improve Flex Stacker storage alignment

Test Plan and Hands on Testing

Tested offsets with protocol: hardware-testing/hardware_testing/protocols/labware_stack_offset_test.py

Changelog

  • added stacking offsets to version files 2.json and 3.json for well plates in list [https://opentrons.atlassian.net/browse/EXEC-1612]

Review requests

Risk assessment

  • tested offsets with 2 labware, have not tested a stacker completed filled

@rclarke0 rclarke0 requested review from a team as code owners June 24, 2025 19:13
@rclarke0 rclarke0 requested review from vegano1 and ahiuchingau June 24, 2025 19:14
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 24.77%. Comparing base (4b97d22) to head (50a1b7e).
Report is 7 commits behind head on edge.

Files with missing lines Patch % Lines
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% 37 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18725       +/-   ##
===========================================
- Coverage   56.91%   24.77%   -32.14%     
===========================================
  Files        3243     3284       +41     
  Lines      282323   286141     +3818     
  Branches    35451    29382     -6069     
===========================================
- Hits       160680    70891    -89789     
- Misses     121440   215229    +93789     
+ Partials      203       21      -182     
Flag Coverage Δ
protocol-designer 19.09% <0.00%> (ø)
step-generation 5.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% <0.00%> (-96.24%) ⬇️

... and 1790 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we missed a few files

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested for the Pipfile thing, and for labware version bumps (which are already being worked on in #18726.)

@vegano1 vegano1 requested a review from a team as a code owner June 26, 2025 21:11
@vegano1 vegano1 requested review from jerader and removed request for a team June 26, 2025 21:11
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good once tests pass! Just holding approval for the Pipfile/Pipfile.lock thing above. I don't think either of those files need to be modified here?

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vegano1
Copy link
Contributor

vegano1 commented Jun 27, 2025

The PD CI test is weird, it's passing locally but failing on CI. I spoke with @jerader and this should be fine to merge in.

@vegano1
Copy link
Contributor

vegano1 commented Jun 27, 2025

Latest changes look good once tests pass! Just holding approval for the Pipfile/Pipfile.lock thing above. I don't think either of those files need to be modified here?

@SyntaxColoring
correct, we dont need them and have been reverted.

@vegano1 vegano1 requested a review from SyntaxColoring June 27, 2025 18:24
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@rclarke0 rclarke0 merged commit ad12ac0 into edge Jun 27, 2025
52 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants