runner timestamps invariant #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ensures that timeline record timestamps are formatted using an invariant culture for consistency.
- Added
CultureInfo.InvariantCulturetoToStringcalls forStartedAtandCompletedAt - Aligns with previous fixes for timestamp formatting in this file
Comments suppressed due to low confidence (1)
src/Sdk/WebApi/WebApi/ResultsHttpClient.cs:523
- Add a unit test (e.g., in
Test/L0/WebApi/ResultsHttpClientL0.cs) to verify thatConvertTimelineRecordToStepproduces the expected timestamp string under different culture settings, ensuring the invariant-culture formatting is applied.
StartedAt = r.StartTime?.ToString(Constants.TimestampFormat, CultureInfo.InvariantCulture),
ericsciple
approved these changes
Jun 2, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from this PR, there were a couple of instances of this that were not addressed in the same file.