Skip to content

Fix: Show warning instead of failing the run #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix: Show warning instead of failing the run #517

wants to merge 3 commits into from

Conversation

cino
Copy link

@cino cino commented Jun 13, 2022

Description:
As there are currently issues with the caching service which is breaking workflows using the caching I suggest we change the workflow to only fail when there are configuration errors. When anything else goes wrong in the workflow, like a 503 error there should be a warning but let the workflow run continue.

Having caching available or not should not be breaking the workflow, instead, just continue as if there is no cache.

Related issue:
#516

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@cino cino requested a review from a team June 13, 2022 11:33
@cino
Copy link
Author

cino commented Jun 13, 2022

Check dist action was failing due to me not committing the dist files, however, I think someone should update the contributors.md

@IvanZosimov
Copy link
Contributor

Hi, @cino 👋 ! Thank you for your contribution a lot! Unfortunately, we decided to implement such error handling by ourselves on another let's say deeper level. We really appreciate your effort and willingness to help! ❤️

By now I'm going to close this PR, if you have any questions or suggestions feel free to ping us.

@cino cino deleted the warn-instead-of-fail branch June 15, 2022 09:01
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants