Skip to content

catch2 time units are ignored when graphing and generating alerts #122

@paradust7

Description

@paradust7

When using the "catch2" extractor, the time units, "ms", "us", etc, are extracted and printed, but otherwise ignored.

This results in broken graphs when the time is near a unit boundary:

broken_graph

It also results in false alerts:

Screenshot from 2022-05-04 17-17-24

Activity

wwerkk

wwerkk commented on Apr 18, 2024

@wwerkk

Any news on this? getRatio doesn't involve unit calculation atm, though it seems like an easy fix for a problem that makes this action pretty useless for catch:

function getRatio(tool: ToolType, prev: BenchmarkResult, current: BenchmarkResult) {

linked a pull request that will close this issue on Apr 18, 2024
self-assigned this
on May 19, 2024
added
bugSomething isn't working
on May 19, 2024
moved this from Todo to In Progress in Benchmark Action Boardon May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @ktrz@wwerkk@paradust7

    Issue actions

      catch2 time units are ignored when graphing and generating alerts · Issue #122 · benchmark-action/github-action-benchmark