Skip to content

feat: stabilize --node-conditions flag #29628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

feat: stabilize --node-conditions flag #29628

merged 4 commits into from
Jun 26, 2025

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 5, 2025 •
edited
Loading

Stabilizes --conditions flag added in #29586.

Closes #23757

@bartlomieju bartlomieju mentioned this pull request Jun 5, 2025
Merged
@bartlomieju
Copy link
Member Author

Wait for denoland/docs#1802 to land before merging this.

@bartlomieju bartlomieju added this to the 2.4.0 milestone Jun 5, 2025
@mintydev789
Copy link

I think this is a bit early regardless, since we've not had enough time to test that it works as expected. The unstable flag was just rolled out the other day.

@bartlomieju
Copy link
Member Author

I think this is a bit early regardless, since we've not had enough time to test that it works as expected. The unstable flag was just rolled out the other day.

This is just a PR - 2.4.0 is scheduled to be released at the end of the month so there's gonna be at least a couple patch releases before it gets stabilized.

@dsherret dsherret changed the title feat: Stabilize --node-conditions flag feat: stabilize --node-conditions flag Jun 6, 2025
@mintydev789
Copy link

@bartlomieju oh, gotcha

@bartlomieju bartlomieju mentioned this pull request Jun 25, 2025
Merged
bartlomieju added a commit that referenced this pull request Jun 26, 2025
@bartlomieju
feat: rename --unstable-node-conditions to --unstable-conditions (#29885
1192bc0 
)

The `DENO_NODE_CONDITIONS` env var was renamed to `DENO_CONDITIONS`.

Ref #29628
Ref #23757
@bartlomieju bartlomieju requested a review from dsherret June 26, 2025 11:15
@bartlomieju bartlomieju force-pushed the stabilize_node_conditions branch from 1025f12 to bfa33bd Compare June 26, 2025 19:49
marvinhagemeister
marvinhagemeister approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 9913311 into denoland:main Jun 26, 2025
18 checks passed
@bartlomieju bartlomieju deleted the stabilize_node_conditions branch June 26, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Support for custom conditional exports in npm specifier
4 participants
@bartlomieju @mintydev789 @marvinhagemeister @dsherret