feat: Add expression formatting in CSS strings for components #29763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new function `format_expressions_in_text` handles JS expressions in text, allowing for temporary placeholders during formatting of component files. The `format_html` function preprocesses expressions before markup parsing and restores them after formatting.
…new formatting test for Vue - new `badly_formatted.vue` and its fixed counterpart - updated existing Svelte test file to include dynamic style
|
|
janosh
changed the title
dsherret
reviewed
Jun 23, 2025
Comment on lines
+481
to
+482
| "svelte" | "astro" => (r"\{([^{}]+)\}", "{", "}"), | ||
| "vue" => (r"\{\{([^{}]+)\}\}", "{{", "}}"), |
There was a problem hiding this comment.
This seems very error prone to do (ex. it would format within comments). Probably it should be handled by markup_fmt instead and it can call out to format these expressions with the appropriate formatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26999
new function
format_expressions_in_texthandles JS expressions in text, allowing for temporary placeholders during formatting of component files. Theformat_htmlfunction preprocesses expressions before markup parsing and restores them after formatting.tested for Svelte and Vue files:
badly_formatted.vueand its fixed counterpart