Skip to content

fix: pptx shape order #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mawi12345
Copy link
Contributor

@mawi12345 mawi12345 commented May 25, 2025

The mspowerpoint backend iterates through the shapes in the slides in the order in which they were inserted. This is particularly a problem if the title of a slide is deleted and inserted again (by clicking on the placeholder). This PR changes the order from top to bottom and from left to right.

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented May 25, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: Martin Wind <martin.wind@im-c.at>
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@cau-git
Copy link
Contributor

cau-git commented Jun 10, 2025

@mawi12345 I agree that the reading order is ill-defined in Powerpoint since it is not necessarily the order in which elements were inserted or created. However, sorting it from top to bottom and from left to right is not a safe approach either. I would propose to address this in a more generic way by leveraging the reading-order model we have in docling already. It is currently applied in our PDF pipeline only. For reference, check here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants