Skip to content

chore(miner): remove deprecated code as a result of FIP-0100 #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

tediou5
Copy link
Contributor

@tediou5 tediou5 commented Apr 22, 2025

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 22, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Apr 22, 2025
@tediou5 tediou5 changed the title [skip changelog] chore(FIP-0100): remove deprecated code [skip changelog] chore: remove deprecated code(FIP-0100) Apr 22, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tediou5 tediou5 changed the title [skip changelog] chore: remove deprecated code(FIP-0100) [skip changelog]chore(FIP-0100): remove deprecated code Apr 22, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tediou5 tediou5 changed the title [skip changelog]chore(FIP-0100): remove deprecated code [skip changelog] chore: remove deprecated code Apr 22, 2025
@github-actions github-actions bot dismissed their stale review April 22, 2025 02:47

PR title now matches the required format.

@tediou5 tediou5 moved this from ⌨️ In Progress to 🔎 Awaiting Review in FilOz Apr 22, 2025
@BigLep BigLep added the skip/changelog This change does not require CHANGELOG.md update label Apr 22, 2025
@BigLep BigLep changed the title [skip changelog] chore: remove deprecated code chore(miner): remove deprecated code as a result of FIP-0100 Apr 22, 2025
@github-actions github-actions bot dismissed their stale review April 22, 2025 04:45

PR title now matches the required format.

@BigLep BigLep requested a review from Stebalien April 22, 2025 04:45
@BigLep
Copy link
Member

BigLep commented Apr 22, 2025

@Stebalien : can you please look given @rvagg is out?

@BigLep BigLep moved this from 🐱 Todo to 🔎 Awaiting Review in nv25 Track Board Apr 22, 2025
@BigLep
Copy link
Member

BigLep commented Apr 22, 2025

(This is followup to #12919 now that we've upgraded to nv25)

@rjan90 rjan90 dismissed github-actions[bot]’s stale review April 30, 2025 06:50

title has been fixed

@BigLep
Copy link
Member

BigLep commented May 6, 2025

@rvagg : I assume you'll look later this week when you come back online.

@BigLep BigLep requested a review from rvagg May 6, 2025 21:44
@tediou5 tediou5 requested a review from rvagg May 13, 2025 06:04
@rjan90
Copy link
Contributor

rjan90 commented May 26, 2025

@rvagg could you look over the latest changes here, and see if things look okay so that we can get it merged?

@BigLep BigLep requested a review from Copilot June 3, 2025 04:39
Copilot

This comment was marked as outdated.

@BigLep
Copy link
Member

BigLep commented Jun 10, 2025

@rvagg : repinging in case you have bandwidth now for this.

@rvagg rvagg requested a review from Copilot June 25, 2025 03:25
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's do it! so sorry for the delay @tediou5 and thanks for the hard thinky work here

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jun 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated aggregation and basefee-threshold code per FIP-0100.

  • Consolidates partition/declaration limits by using policy.DeclarationsMax.
  • Drops deprecated config fields (AggregateCommits, AggregateAboveBaseFee, BatchPreCommitAboveBaseFee) and related logic.
  • Cleans up default configs, CLI commands, policy actors, and tests to eliminate FIP-0100 leftovers.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
storage/wdpost/wdpost_run.go Use policy.DeclarationsMax instead of deprecated GetDeclarationsMax
storage/pipeline/terminate_batch.go Remove deprecated FIP-0100 declaration-limit checks
storage/pipeline/sealiface/config.go Drop deprecated aggregation-and-fee config fields
storage/pipeline/precommit_batch.go Remove basefee-threshold batching logic
storage/pipeline/commit_batch.go Remove aggregation flags and outdated fee computation
node/modules/storageminer.go Remove deprecated sealing config assignments
node/config/types.go Delete deprecated config options
node/config/doc_gen.go Clean up documentation for removed config fields
node/config/def.go Remove deprecated default config values
itests/sector_pledge_test.go Update tests to drop deprecated fee-threshold config mutation
itests/sector_miner_collateral_test.go Remove obsolete aggregation settings in test setup
itests/direct_data_onboard_test.go Remove outdated aggregate setting from test configuration
documentation/en/default-lotus-miner-config.toml Clean default config file of deprecated entries
cli/spcli/sectors.go Replace deprecated GetDeclarationsMax usage with DeclarationsMax
chain/actors/policy/policy.go.template Remove deprecated policy-template methods
chain/actors/policy/policy.go Remove deprecated policy methods
Comments suppressed due to low confidence (1)

storage/pipeline/commit_batch.go:223

  • Use %w instead of %s when formatting errors so the original error can be properly wrapped and unwrapped.
		return nil, xerrors.Errorf("getting network version: %s", err)

@rvagg rvagg force-pushed the chore/remove-deprecated-code branch from 2755132 to ade0ac9 Compare June 25, 2025 03:36
@rvagg rvagg force-pushed the chore/remove-deprecated-code branch from ade0ac9 to 8315eb7 Compare June 25, 2025 03:37
@rvagg rvagg removed the skip/changelog This change does not require CHANGELOG.md update label Jun 25, 2025
@rvagg
Copy link
Member

rvagg commented Jun 25, 2025

I've added a CHANGELOG entry in here and rebased on master. @rjan90 I'll let you adjust changelog through the release process if it doesn't suit your preferences.

@rvagg rvagg merged commit cee25a6 into filecoin-project:master Jun 25, 2025
96 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 25, 2025
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to 🎉 Done in nv25 Track Board Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

4 participants