size-limit GitHub Action fails on Node 10 #1089
Description
Current Behavior
$ npx tsdx create mylib
$ cd mylib
$ git init
$ git add --all
$ git commit -m "first commit"
[master (root-commit) 29e0eb0] first commit
10 files changed, 7815 insertions(+)
create mode 100644 .github/workflows/main.yml
create mode 100644 .github/workflows/size.yml
create mode 100644 .gitignore
create mode 100644 LICENSE
create mode 100644 README.md
create mode 100644 package.json
create mode 100644 src/index.ts
create mode 100644 test/blah.test.ts
create mode 100644 tsconfig.json
create mode 100644 yarn.lock
$ git branch -M main
$ git remote add origin https://github.com/tsekityam/mylib.git
$ git push -u origin mainThe project is pushed to GitHub, and CI is triggered. However, the CI task Build, lint, and test on Node 10.x and ubuntu-latest results in failure.
The error is
error @size-limit/file@6.0.3: The engine "node" is incompatible with this module. Expected version "^12.0.0 || ^14.0.0 || >=16.0.0". Got "10.24.1"
14
error Found incompatible module.
Expected behavior
All the CI task ran and completed successfully.
Suggested solution(s)
Remove node@10 from supported engine list.
Additional context
size-limit package removed node@10 support from 5.0. Node@10 is not supported anymore. We should remove it instead of downgrade size-limit package to 4.X
Your environment
npx: installed 1 in 1.55s
System:
OS: macOS 11.6
CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
Memory: 183.74 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.18.0 - /usr/local/opt/node@14/bin/node
Yarn: 1.22.11 - /usr/local/bin/yarn
npm: 6.14.15 - /usr/local/opt/node@14/bin/npm
Browsers:
Edge: 94.0.992.47
Firefox: 92.0
Safari: 15.0
npmPackages:
tsdx: ^0.14.1 => 0.14.1
typescript: ^4.4.4 => 4.4.4
Metadata
Metadata
Assignees
Projects
Milestone
Relationships
Participants
Activity
[-]GitHub CI failure[/-][+]size-limit GitHub Action fails on Node 10[/+]According to issue 1089 I removed support for node 10 again.