disable progress-estimator logging (for lerna run --stream build or CI) #689
Description
In CI environment or with lerna run --stream build it is desired to not clean line. This is caused by fancy logger (from progress-estimator)
Current Behavior
Fancy progress estimator appear in console on tsdx build.
This is not as cool as it should be in some cases,
it may overwrites output of different process run in parallel i.e. with lerna --stream
Desired Behavior
Possibility to turn on no line-destructive logger
Suggested Solution
Replace fancy progress-estimator with primitive console.log if:
- CI environment is detected
process.env.CI - new flag
--no-estimateis set - (non std-out output detected)
Who does this impact? Who is this for?
- CI environments (possibly automatically on)
- People using
lerna --stream
Metadata
Metadata
Assignees
Labels
Projects
Milestone
Relationships
Participants
Activity
[-]fix `lerna --stream` build output[/-][+]fix `lerna run --stream build` output[/+][-]fix `lerna run --stream build` output[/-][+]disable progress-estimator logging (for `lerna run --stream build` or CI)[/+]agilgur5 commentedon Apr 21, 2020
This sounds like a reasonable feature to have. Alternatively, would a
--silentconfig option work for you? All of TSDX's tests run in parallel as well and it makes for quite messy output, so I've been thinking of adding a silencing option for that alone.--silentmight be preferred for CI too (if you like clean logs). But yea we could check for non-TTY env (process.stdout.isTTY) or for CI env(process.env.CI) to auto-set this or aconsole.logoption.I'm not sure what a
console.logalternative would be called; should be more generic than--no-estimatebut I can't think of it off the top of my head (I feel like there's a term for this).langpavel commentedon Apr 24, 2020
@agilgur5
--silentis not what I'm looking for. Build and test output is quite useful. (You may send everything to/dev/nulland result will be the same :-) )I'm not using
tsdx testrunner in monorepo, only in one package if needed (for monorepo I have global jest config)Sad is all the fancy logging output without respect to stupid terminals and text logs.
I can possibly prepare PR with
--no-estimatehelt commentedon Jul 3, 2020
lerna uses a global
--no-progressflag, hence i suppose to stick with their naming convention.