Skip to content

Chore: Mobile: Add internal support for taking multiple pictures from a camera component #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request adds a currently-unused camera wrapper view (CameraViewMultiPage.tsx) and tests.

Goal: Simplify the planned pull request to add support for scanning smart notebooks (e.g. Rocketbook).

@laurent22
Copy link
Owner

Please fix the conflict. Otherwise it's ready to merge so feel free to do so once it's fixed

@laurent22
Copy link
Owner

Sorry, again another conflict

@laurent22
Copy link
Owner

@personalizedrefrigerator, when you have a moment please fix this conflict and feel free to merge once it's done

@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Jun 17, 2025

@personalizedrefrigerator, when you have a moment please fix this conflict and feel free to merge once it's done

Thank you for reminding me! The conflict should now be fixed. I plan to merge after CI finishes running.

@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Jun 17, 2025

The CI failure is caused by an incomplete merge — the tests were written for an old version of react-native-testing-library. Before merging, I should:

  • Update the failing tests.
  • (Optional) Quickly verify that the new React Native version doesn't cause issues with the UI when the multi-page camera is shown and run on a device — tested on web using the mocked CameraView component.

@laurent22 laurent22 merged commit a33fb57 into laurent22:dev Jun 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants