-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Chore: Mobile: Add internal support for taking multiple pictures from a camera component #12357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Mobile: Add internal support for taking multiple pictures from a camera component #12357
Conversation
The multi-page camera will be used as a part of the Rocketbook importer UI.
Please fix the conflict. Otherwise it's ready to merge so feel free to do so once it's fixed |
Sorry, again another conflict |
@personalizedrefrigerator, when you have a moment please fix this conflict and feel free to merge once it's done |
Thank you for reminding me! The conflict should now be fixed. I plan to merge after CI finishes running. |
The CI failure is caused by an incomplete merge — the tests were written for an old version of
|
Summary
This pull request adds a currently-unused camera wrapper view (
CameraViewMultiPage.tsx
) and tests.Goal: Simplify the planned pull request to add support for scanning smart notebooks (e.g. Rocketbook).