Desktop: Fixes #12419: Ensure min and max validation is enforced when setting is not yet present #12553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -456,4 +456,18 @@ describe('models/Setting', () => { | |||
| await Setting.saveAll(); | |||
| } | |||
| }); | |||
|
|
|||
| test('should enforce min and max values for when the setting is already in the cache and when it is not', async () => { | |||
There was a problem hiding this comment.
Thank you for adding a test!
|
This looks good to me. Thank you for fixing this! |
personalizedrefrigerator
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue whereby the min / max value validation is not enforced for integer type settings, when the value is not currently present in the settings.json file. Currently, the validation is only enforced if the setting has been changed before and therefor is present. This change fixes a gap in the validation logic, which will align the behaviour to be the same for insert and update of setting values. I have manually tested this resolves the issue, as well as adding a test unit
This fixes #12419