[Sistent] Added Toolbar Component #6502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lakshyajn <lakshyajain0740@gmail.com>
|
I think these tests are failing due to not enough disk space left for checking or something like that, I did the --depth=1 as well but I still received array buffer full errors and memory full errors, and I have to clean cache and start dev again and again. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
There was a problem hiding this comment.
please revert changes from package.json and package-lock.json
stale
bot
removed
issue/stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5950
Notes for Reviewers
So, I added the toolbar component as required, but the content is common and can be changed, I tried to keep the format same as button component, and would like to do further changes if needed.
I modified package.json (updated few dependencies of plugins, that was giving error for "length" was not recognised.
I added 4 files for the toolbar component just like the button component.
Also, modified the src/sections/Projects/Sistent/components/content.js for adding this.
I tested it before making this PR, please review it.
Signed commits