Skip to content

fix/Multiple-Overlapping-Tooltips-Appear-on-Hover#6445 #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abbiekuma
Copy link

Description

This PR fixes #6445

Notes for Reviewers

Signed commits

  • [✅] Yes, I signed my commits.

Signed-off-by: Yu Luo <abbieluo.yu@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 10, 2025

🚀 Preview for commit 2944749 at: https://684786ba70e65ad94994bfba--layer5.netlify.app

@LibenHailu
Copy link
Contributor

image
Hi @abbiekuma I am not seeing service mesh interface compliance table on the deployed link, can you check?

@abbiekuma
Copy link
Author

abbiekuma commented Jun 10, 2025

image Hi @abbiekuma I am not seeing service mesh interface compliance table on the deployed link, can you check?


Hi @LibenHailu !
While working on the feature, I noticed that the Service Mesh Interface compliance table doesn’t appear unless data is successfully fetched from the API due to CORS restrictions. To address this and make the component visible during development, I used src/collections/landscape/smi.js/smi_data as mock data to view the table, and the issue was successfully resolved in my local environment.

layer5_6445.mov

@LibenHailu
Copy link
Contributor

local environment.

@abbiekuma Hmm, it doesn't seem to be working in production. Could you take a look and see what might be causing the issue?

@abbiekuma
Copy link
Author

Just to clarify, when you say it’s not working, are you referring to the table still being missing, or the hover overlap issue still persists?

@LibenHailu
Copy link
Contributor

Just to clarify, when you say it’s not working, are you referring to the table still being missing, or the hover overlap issue still persists?

The table is missing, here is the preview, https://684786ba70e65ad94994bfba--layer5.netlify.app/service-mesh-landscape

@abbiekuma
Copy link
Author

The reason you're not seeing the SMI table is becuase the data fetch is being blocked by a CORS policy. For now, I’m using mock data locally so I can continue development so that's why it shows up on my end but not yours.
Screenshot 2025-06-11 at 10 47 53 AM

@LibenHailu
Copy link
Contributor

The reason you're not seeing the SMI table is becuase the data fetch is being blocked by a CORS policy. For now, I’m using mock data locally so I can continue development so that's why it shows up on my end but not yours.

Can you load the data locally? if not we have to check the backend and update the CORS policy?

@abbiekuma
Copy link
Author

Hello, I I followed the suggestion at Slack to open a new Chrome window with security options disabled. This bypassed the CORS restrictions, and it worked! the data loaded successfully. Here is the updated recording👇

updated_layer5_6445.mov

@LibenHailu
Copy link
Contributor

LGTM

@abbiekuma abbiekuma requested a review from randychilau June 15, 2025 16:51
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbiekuma Please revert these whitespace, formatting changes

@vishalvivekm
Copy link
Contributor

@abbiekuma
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Jun 16, 2025

🚀 Preview for commit 23e5755 at: https://684ffe1d08ec02c8f6f58afe--layer5.netlify.app

Signed-off-by: Abbie - Yu Luo <149909888+abbiekuma@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jun 23, 2025

🚀 Preview for commit e5f02ba at: https://68599115186515835549a12c--layer5.netlify.app

@abbiekuma
Copy link
Author

abbiekuma commented Jun 23, 2025

Here is how it looks in mobile view. @vishalvivekm @vr-varad
I also updated the format. The previous formatting was changed by Prettier, but I’ve now adjusted it back to the original style.

Screen.Recording.2025-06-23.at.1.37.12.PM.mov

@l5io
Copy link
Contributor

l5io commented Jun 25, 2025

🚀 Preview for commit 749aa4c at: https://685bcee22a8410e58b79bf5e--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Overlapping Tooltips Appear on Hover
4 participants