Skip to content

[HashRecognize] Add CRC optz tests with type-mismatch #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

artagnon
Copy link
Contributor

No description provided.

Copy link

@pfusik pfusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new tests seem to be copy-pasted with some minor changes.
Can we de-duplicate this code with templates or preprocessor?

@artagnon
Copy link
Contributor Author

artagnon commented Jun 23, 2025

These new tests seem to be copy-pasted with some minor changes. Can we de-duplicate this code with templates or preprocessor?

Thanks, I'd been meaning to do this, and finally got around to it: #262. To keep the tests as simple as possible, I've stuck to C pre-processor macros. Will rebase once that lands.

Copy link

@pfusik pfusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artagnon artagnon merged commit ff244c4 into llvm:main Jun 23, 2025
1 check passed
@artagnon artagnon deleted the hr-stress branch June 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants