Skip to content

Update: Adapt tray icon to theme changes #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

HO-COOH
Copy link

@HO-COOH HO-COOH commented Jun 30, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the time of the contributors, who have to spend their free time reviewing, fixing, and testing code that does not even compile, breaks other features, or does not introduce any useful changes. Thank you for your understanding.

This PR will utilize Community ToolKit's ThemeListener and update the tray icon to the correct light/dark mode in time. Unlike currently it only updates when there is a package update check, causing this
image

But the current ThemeListener does not work under WinUI3, and I have submitted another PR to them to get that fixed. I will mark this WIP with draft for now, and will switch the status to be ready once that PR gets merged.

@chris-tietgen
Copy link

I like this change. Is there a similar ticket to show the new updates available indicator on the taskbar icon?

@marticliment
Copy link
Owner

what do you mean?

@chris-tietgen
Copy link

I mean that the icon that displays on the taskbar doesn't show that green dot that appears on the icon in the tray area, so I can't tell at a glance that updates are available from that icon.

image

@marticliment
Copy link
Owner

I am afraid this is currently not possible, due to limitations with Windows AppSdk and Unpackaged apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants