Skip to content

Rename src folders and fix error in CD Pipelines #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kottofy
Copy link
Contributor

@kottofy kottofy commented Oct 28, 2024

This PR:

  • renames all src folders from example src/nyc_src to src/nyc_taxi
  • Adds a continue on error for the cd workflow when copying the src/{{model}}/common folder which doesn't exist in all models. Without this, the pipeline fails

Resolves issue #192

@kottofy kottofy changed the title Fix CD Workflows Rename src folders Oct 28, 2024
@kottofy kottofy requested a review from sweanan October 28, 2024 20:35
@kottofy kottofy self-assigned this Oct 28, 2024
@kottofy kottofy changed the title Rename src folders Rename src folders and fix error in CD Pipelines Nov 7, 2024
@@ -94,6 +94,7 @@ jobs:
shell: bash
run: |
[ -d "src/${{ inputs.model_type }}/common/" ] && cp -r src/${{ inputs.model_type }}/common/* model/${{ inputs.model_type }}/online
continue-on-error: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if the azdo continue-on-error still produces a warning/error log? if not, it may be useful to log it via the below bash command:

 if [ -d "src/${{ inputs.model_type }}/common/" ]; then
              cp -r src/${{ inputs.model_type }}/common/* model/${{ inputs.model_type }}/online
            else
              echo "Warning: Directory src/${{ inputs.model_type }}/common/ does not exist" >&2
            fi

Copy link
Collaborator

@agonzalez2014 agonzalez2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment around ensuring that a log message is produced when the YML job for "copying common files" fails. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants