-
Notifications
You must be signed in to change notification settings - Fork 16
Rename src folders and fix error in CD Pipelines #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -94,6 +94,7 @@ jobs: | |||
shell: bash | |||
run: | | |||
[ -d "src/${{ inputs.model_type }}/common/" ] && cp -r src/${{ inputs.model_type }}/common/* model/${{ inputs.model_type }}/online | |||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know if the azdo continue-on-error
still produces a warning/error log? if not, it may be useful to log it via the below bash command:
if [ -d "src/${{ inputs.model_type }}/common/" ]; then
cp -r src/${{ inputs.model_type }}/common/* model/${{ inputs.model_type }}/online
else
echo "Warning: Directory src/${{ inputs.model_type }}/common/ does not exist" >&2
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 comment around ensuring that a log message is produced when the YML job for "copying common files" fails. LGTM!
This PR:
src/nyc_src
tosrc/nyc_taxi
src/{{model}}/common
folder which doesn't exist in all models. Without this, the pipeline failsResolves issue #192