Adding an item in the status bar for Diff Information - specially to say the content is identical #252055
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for the PR! I think this has to be integrated somehow with the blue button that we show when there are only whitespace changes, but whitespace changes are hidden. Btw. we already disable the arrow up/down buttons to indicate that there are no changes! (this is very subtle though) |
This comment was marked as resolved.
This comment was marked as resolved.
|
@hediet reimplemented using notifications, let me know what you think |
marcopelegrini
force-pushed
the
users/mpelegrini/Status-bar-diff-element-info
branch
from
945efd3 to
cefc9d7
Compare
marcopelegrini
force-pushed
the
users/mpelegrini/Status-bar-diff-element-info
branch
from
cefc9d7 to
24aa09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a notification for when comparing two identical contents
Resolves: #243352
(when playing the video, make sure to move the mouse out to the side to hide the controls so you can see the notification)
diffinfov2.mp4
--
Old implementation using status bar left in the commit history for reference