-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix(testing): add fallback option to file type validator #15226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yasir-Rafique
wants to merge
11
commits into
nestjs:master
Choose a base branch
from
Yasir-Rafique:fix/file-type-validator-compatibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(testing): add fallback option to file type validator #15226
Yasir-Rafique
wants to merge
11
commits into
nestjs:master
from
Yasir-Rafique:fix/file-type-validator-compatibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build aa574eec-13f3-4118-a75c-4fbdd7e27af8Details
💛 - Coveralls |
…idator-compatibility
…idator-compatibility
All conflicts have been resolved, and checks are passing. Ready for review |
Hardanish-Singh
approved these changes
Jun 6, 2025
It seems it's approved but conflict remains, can you please resolve the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the FileTypeValidator fails when file-type is unable to determine the MIME type — particularly for file formats with undetectable signatures. This can cause valid uploads to fail unexpectedly.
Additionally, the related unit test did not cover scenarios involving fallback logic or validator option validation.
Issue Number: #15055
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR resolves compatibility issues related to MIME type detection and improves developer experience by making file validation more fault-tolerant in real-world uploads. It also keeps dependencies aligned with current CommonJS-based usage patterns.