Skip to content

Bug: Improve lighthouse accessibility score. #87

@bdougie

Description

@bdougie
Member

Describe the bug

This was reported here.

Looks really cool, but doesn't feel like a website. Any reason why hyperlinks are marked up as

? Also, why do links that lead to a different page trigger a scroll up animation on the same page while page contents changes? It feels disorienting.

Looks like there are few places where we are doing Button or Link is rendering a <div href/>. Opening this issue for tracking reasons.

I have not yet triaged this myself, but we will want to make sure this site passes all accessibility tests now that it is live. This was an oversight on my part.

Steps to reproduce

Run the lighthouse on the site and report issues here. Depending on scope, we can open separate issues for fix in one PR.

Screen Shot 2022-12-14 at 9 34 22 AM

Affected services

opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs

Activity

takanome-dev

takanome-dev commented on Dec 14, 2022

@takanome-dev

All the buttons except the subscribe newsletter are divs with href.

I ran lighthouse on Firefox and Brave and it got pretty good score imh.
Here are some screenshots:

Brave Desktop

opensauced_lighthouse_1

Brave Modile

opensauced_lighthouse_3

Firefox mobile

opensauced_lighthouse_2

Common for both on mobile

firefox_1
firefox_2
firefox_3
firefox_4
firefox_5
firefox_6

bdougie

bdougie commented on Jan 3, 2023

@bdougie
MemberAuthor

I think the focus for this issue should be improving the accessibility score. If updating the links does not improve the score, we should avoid it. I am updating the title to reflect this.

changed the title [-]Bug: <div href> [/-] [+]Bug: Improve lighthouse accessibility score.[/+] on Jan 3, 2023
CBID2

CBID2 commented on Aug 11, 2023

@CBID2

@EmmaDawsonDev, I think you can share some great insights on this.

EmmaDawsonDev

EmmaDawsonDev commented on Aug 11, 2023

@EmmaDawsonDev

Definitely happy to take a look and do an accessibility audit. I'd prioritise fixing the links/buttons over raising the lighthouse score as that's something critical for keyboard users to access the site and not something lighthouse can pick up. But I'm sure there's a lot of small tweaks that can make a big difference

dev-phantom

dev-phantom commented on Sep 17, 2023

@dev-phantom
Contributor

.take

github-actions

github-actions commented on Sep 17, 2023

@github-actions
Contributor

Thanks for taking this on! If you have not already, join the conversation in our Discord

linked a pull request that will close this issue on Sep 9, 2024
shiv343

shiv343 commented on Jun 6, 2025

@shiv343

is this issue still open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @bdougie@EmmaDawsonDev@dev-phantom@takanome-dev@CBID2

      Issue actions

        Bug: Improve lighthouse accessibility score. · Issue #87 · open-sauced/landing-page