fix: do not reuse branch if cache fingerprint doesn't match #36616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And this is the wider fix, but could come after: #36618 |
viceice
reviewed
Jun 21, 2025
| branchState: BranchCache, | ||
| commitFingerprint: string, | ||
| ): boolean { | ||
| ): 'no-fingerprint' | 'no-match' | 'matched' { |
There was a problem hiding this comment.
why not using CacheFingerprintMatchResult here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes problem where branch reuse caused incorrect results when results were shrinking or growing.
Note: only fixes the case where cache is used. Problem still exists for non-cache.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: