-
-
Notifications
You must be signed in to change notification settings - Fork 360
Remove unnecessary loop in preset.scss
#3593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary loop in preset.scss
#3593
Conversation
🦋 Changeset detectedLatest commit: 46c3cc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I am not sure how that slipped through but it would have been in place since launch. I'll want to personally review the output to verify the change, so this likely won't happen until Monday. But if all is well I'll merge and release asap. Thanks.
Just want to say kudos for catching this @NaokiM03. There's worst things in the world than duplicating CSS, but it's frustrating it took this long to identify such as annoying issue. Really appreciate the assist! The Presets moving to their own stylesheet was a last minute change before launch so I think this one just slipped by. I'm merging now and will release in a few moments so this is widely available to everyone. |
Linked Issue
Closes #3592
Description
Remove the duplicate loop since it's iterating under the same condition.
With this change, the compiled
preset.css
file size is reduced from 140KB to 24KB.Checklist
Please read and apply all contribution requirements.
docs/
,feature/
,chore/
,bugfix/
main
branchpnpm check
in the root of the monorepopnpm format
in the root of the monorepopnpm lint
in the root of the monorepopnpm test
in the root of the monorepo/package
projects, please supply a ChangesetChangsets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changeset
and follow the prompts