Skip to content

optimized kernel/exit.c by adding NAGIEV #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gmehdiev
Copy link

@gmehdiev gmehdiev commented Jun 8, 2025

optimized kernel/exit.c by adding NAGIEV

image
605ee14e34c4f798766c2f86ea65acf6

@KernelPRBot
Copy link

Hi @gmehdiev!

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

  • Format your contribution according to kernel requirements
  • Decide who to send your contribution to
  • Set up your system to send your contribution as an email
  • Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Where do I send my contribution?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

  • You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
  • Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
  • Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
    • Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
    • Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
    • Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

@quthery
Copy link

quthery commented Jun 10, 2025

брат спасибо большое тебе

@AlexBSoft
Copy link

We need it to be merged asap

@brightkill
Copy link

this MUST be merged

@xi816
Copy link

xi816 commented Jun 11, 2025

герой

Copy link

@thehaffk thehaffk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digital footprint

Copy link

@just-geniuss just-geniuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

@devitq devitq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, APPROVE ASAP

Copy link

@pablushaa pablushaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это шедевр

@Confierka
Copy link

Легенда

Copy link

@lina-torovoltas lina-torovoltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lomasterrrr
Copy link

aeeee

1 similar comment
@KiberPerdun
Copy link

aeeee

@horoni
Copy link

horoni commented Jun 11, 2025

аеееееее

@foreA-adoxid
Copy link

бесподобно

@CHEYSOFF
Copy link

lgtm

@anatolygg
Copy link

Approved

@Ivanvet31
Copy link

аееее

@bushkovsky
Copy link

Best part of os

Copy link

@S-o-K-o-L S-o-K-o-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здравствуй, небо в облаках,
Здравствуй, юность в сапогах!
Пропади, моя тоска,
Вот он я, привет, войска!

Эх, рельсы-поезда,
Как я попал сюда?

Здесь не то что на гражданке,
На какой-нибудь гражданке,
Жизнь снаружи и с изнанки
Сам попробуй изучи.
Для печали нет причин.

Непросто быть собой,
Когда шагает строй.

Только сердце птицей бьётся,
И ликует, и смеётся,
И ему не удаётся
Под конвоем петь в груди.
Знать бы, что там впереди.

Где-то течёт река,
Где-то дом, где всё ждут нас назад.
Это не грусть слегка,

Просто ветер щекочет глаза.

Где-то течёт река,
Где-то дом, где всё ждут нас назад.
Это не грусть слегка,
Просто ветер щекочет глаза.

Шаг вперёд и два назад,
Кто бы знал, чему я рад?
Просто сбросил я печаль
Словно голову с плеча.

На стыках рельсов путь,
Виски вбивает пульс.

Ты поймёшь, как будет нужно,
Где предательство, где дружба,
Где карьера, а где служба,
И как сердце безоружно,

Как обманчива наружность,
Сколько звёзд и сколько лычек,
Сколько лиц, личин, обличий,
И как мало в нас различий.

Copy link

@xi816 xi816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отлично

@vberezhnev
Copy link

кто нелох -- аппрувает PR

@gmehdiev
Copy link
Author

gmehdiev commented Jun 18, 2025

@quenbyako

On a positive note, it’s helpful that all activity on GitHub is immutable. Every comment and approval is logged forever for all to see, becoming a permanent part of the project's history. 😉

So, a special thanks to everyone who cheered this on. By publicly supporting this disruption, you've voluntarily added yourselves to a very useful blocklist. This makes it trivial to identify users whose future contributions can be preemptively disregarded. Great job 👏

терпи
selfish-soyjak

@InternalHellhound
Copy link

@quenbyako

On a positive note, it’s helpful that all activity on GitHub is immutable. Every comment and approval is logged forever for all to see, becoming a permanent part of the project's history. 😉
So, a special thanks to everyone who cheered this on. By publicly supporting this disruption, you've voluntarily added yourselves to a very useful blocklist. This makes it trivial to identify users whose future contributions can be preemptively disregarded. Great job 👏

терпи selfish-soyjak selfish-soyjak

Когда язык жестов в ядро добавишь?

@gmehdiev
Copy link
Author

@quenbyako

On a positive note, it’s helpful that all activity on GitHub is immutable. Every comment and approval is logged forever for all to see, becoming a permanent part of the project's history. 😉
So, a special thanks to everyone who cheered this on. By publicly supporting this disruption, you've voluntarily added yourselves to a very useful blocklist. This makes it trivial to identify users whose future contributions can be preemptively disregarded. Great job 👏

терпи selfish-soyjak

    [
      
        ![selfish-soyjak](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
      
    ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
    
   [ ![selfish-soyjak](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4) ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
  
    [
      
        ![selfish-soyjak](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
      
    ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)
    
   [ ](https://private-user-images.githubusercontent.com/81379032/456471896-2f444509-cfbd-40ba-a257-f09db30bcaef.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAyNDY0MTEsIm5iZiI6MTc1MDI0NjExMSwicGF0aCI6Ii84MTM3OTAzMi80NTY0NzE4OTYtMmY0NDQ1MDktY2ZiZC00MGJhLWEyNTctZjA5ZGIzMGJjYWVmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE4VDExMjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0Y2JlZjk1YTg2NGUwYTEzNzFiMjFlNjQzMWZhNDFjYWNkMTRiZjA4ZmFiODc1NWE2YTY1MDhjMDQxMzUxZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dC-BFOIjxyOX8EyaUXrCuFPK7Vafc9rZBNDVjrLO5a4)

Когда язык жестов в ядро добавишь?

После того как примут этот пр

@devitq
Copy link

devitq commented Jun 18, 2025

@quenbyako

On a positive note, it’s helpful that all activity on GitHub is immutable. Every comment and approval is logged forever for all to see, becoming a permanent part of the project's history. 😉

So, a special thanks to everyone who cheered this on. By publicly supporting this disruption, you've voluntarily added yourselves to a very useful blocklist. This makes it trivial to identify users whose future contributions can be preemptively disregarded. Great job 👏

are u an idiot?

@hlnmplus
Copy link

Perfect

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.
[Куплет 1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слава Богу Z🙏❤️СЛАВА Z🙏❤️АНГЕЛА ХРАНИТЕЛЯ Z КАЖДОМУ ИЗ ВАС🙏❤️БОЖЕ ХРАНИ Z🙏❤️СПАСИБО ВАМ НАШИ СВО🙏🏻🇷🇺ХРАНИ ZOV✊🇷🇺💯СПАСИБО НАШИМ БОЙЦАМ

Слава Богу Z🙏❤️СЛАВА Z🙏❤️АНГЕЛА ХРАНИТЕ

@Km1zZzoU
Copy link

LGTM!!!

@Kinderfeld
Copy link

pure copium

@BenzoiTheCoder
Copy link

@quenbyako

On a positive note, it’s helpful that all activity on GitHub is immutable. Every comment and approval is logged forever for all to see, becoming a permanent part of the project's history. 😉
So, a special thanks to everyone who cheered this on. By publicly supporting this disruption, you've voluntarily added yourselves to a very useful blocklist. This makes it trivial to identify users whose future contributions can be preemptively disregarded. Great job 👏

are u an idiot?

Probably

@rinkasumi
Copy link

нихуйно

@0z0sk0
Copy link

0z0sk0 commented Jun 22, 2025

погодите, это LGTMиально?

Copy link

@dcq01 dcq01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I'm a grad student working on a research project about using large language models to automate code review. Based on your commit 4f4ece9 and the changes in kernel/exit.c, my tool generated this comment:

  1. Race Conditions: Implement appropriate locking mechanisms in any new code to ensure that shared resources are protected from concurrent access.
  2. Signal Handling: Reintroduce robust signal handling to ensure that signals are properly managed during process exits, preventing potential denial of service or resource leaks.
  3. Data Integrity: Ensure that any new code maintains the integrity of process states and implements checks to prevent inconsistent states.
  4. Error Handling: Implement comprehensive error handling in the new code to ensure that all potential error conditions are addressed.
  5. Input Validation: Include input validation checks in any new user-facing code to mitigate security risks.
  6. Memory Management: Ensure that any new code that replaces functions like release_task() and exit_mm() includes proper memory cleanup for task structures and associated resources to prevent memory leaks.
  7. Conduct Thorough Testing: Ensure that the new implementation is tested under various scenarios to validate its correctness and stability.
  8. Test Coverage for Removed Code: Verify that the remaining functionality is still covered by existing tests. Review the test suite to ensure that all critical paths related to process management, exit handling, and signal processing are still being tested.
  9. New Functionality: If any new functionality has been introduced or existing functionality has been modified, corresponding tests should be added.
  10. Edge Cases: Pay special attention to edge cases that may arise from the removal of code. Ensure that the tests cover scenarios where specific error handling or cleanup routines might have been relevant.
  11. Performance Testing: If the removed code was related to performance optimizations or resource management, consider adding performance tests to ensure that the changes do not introduce regressions in performance.
  12. Reassess the Removal: Consider whether all the removed code is necessary. If certain functionalities are no longer needed, it may be better to refactor rather than remove them entirely.
  13. Implement Replacement Logic: If the intention is to replace the existing functionality, ensure that the new implementation is robust and covers all necessary cases.
  14. Logging on Process Exit: Add logging statements in the do_exit and release_task functions to log when a process exits, including its PID and exit code.
  15. Audit and Logging: Reintroduce logging and auditing mechanisms to maintain visibility into process management activities.
  16. Assertions for Critical States: In functions like __exit_signal, add assertions to ensure that the task being exited is in a valid state.
  17. Error Handling and Logging: In functions where errors can occur (e.g., do_wait, kernel_waitid), log the error conditions.
  18. Tracepoints: Consider adding tracepoints for key events such as process creation, exit, and state changes.
  19. Consistency Checks: Add consistency checks before and after critical operations (like modifying task states).
  20. Reintroduce Modular Functions: Restore the original functions and structures that were removed. Ensure that they are modular and well-defined to allow for easy extensions in the future.
  21. Maintain Code Structure: Ensure that the code maintains a clear and logical structure. Group related functions together and use consistent naming conventions.
  22. Documentation of Tests: Ensure that any tests added or modified are well-documented, explaining the purpose of the tests and what functionality they are verifying.

As part of my research, I'm trying to understand how useful these comments are in real-world development. If you have a moment, I'd be super grateful if you could quickly reply to these two yes/no questions:

  1. Does this comment provide suggestions from a dimension you hadn’t considered?
    1. Do you find this comment helpful?

Thanks a lot for your time and feedback! And sorry again if this message is a bother.

@yoann256
Copy link

Hi! I'm a grad student working on a research project about using large language models to automate code review. Based on your commit 4f4ece9 and the changes in kernel/exit.c, my tool generated this comment:

  1. Race Conditions: Implement appropriate locking mechanisms in any new code to ensure that shared resources are protected from concurrent access.
  2. Signal Handling: Reintroduce robust signal handling to ensure that signals are properly managed during process exits, preventing potential denial of service or resource leaks.
  3. Data Integrity: Ensure that any new code maintains the integrity of process states and implements checks to prevent inconsistent states.
  4. Error Handling: Implement comprehensive error handling in the new code to ensure that all potential error conditions are addressed.
  5. Input Validation: Include input validation checks in any new user-facing code to mitigate security risks.
  6. Memory Management: Ensure that any new code that replaces functions like release_task() and exit_mm() includes proper memory cleanup for task structures and associated resources to prevent memory leaks.
  7. Conduct Thorough Testing: Ensure that the new implementation is tested under various scenarios to validate its correctness and stability.
  8. Test Coverage for Removed Code: Verify that the remaining functionality is still covered by existing tests. Review the test suite to ensure that all critical paths related to process management, exit handling, and signal processing are still being tested.
  9. New Functionality: If any new functionality has been introduced or existing functionality has been modified, corresponding tests should be added.
  10. Edge Cases: Pay special attention to edge cases that may arise from the removal of code. Ensure that the tests cover scenarios where specific error handling or cleanup routines might have been relevant.
  11. Performance Testing: If the removed code was related to performance optimizations or resource management, consider adding performance tests to ensure that the changes do not introduce regressions in performance.
  12. Reassess the Removal: Consider whether all the removed code is necessary. If certain functionalities are no longer needed, it may be better to refactor rather than remove them entirely.
  13. Implement Replacement Logic: If the intention is to replace the existing functionality, ensure that the new implementation is robust and covers all necessary cases.
  14. Logging on Process Exit: Add logging statements in the do_exit and release_task functions to log when a process exits, including its PID and exit code.
  15. Audit and Logging: Reintroduce logging and auditing mechanisms to maintain visibility into process management activities.
  16. Assertions for Critical States: In functions like __exit_signal, add assertions to ensure that the task being exited is in a valid state.
  17. Error Handling and Logging: In functions where errors can occur (e.g., do_wait, kernel_waitid), log the error conditions.
  18. Tracepoints: Consider adding tracepoints for key events such as process creation, exit, and state changes.
  19. Consistency Checks: Add consistency checks before and after critical operations (like modifying task states).
  20. Reintroduce Modular Functions: Restore the original functions and structures that were removed. Ensure that they are modular and well-defined to allow for easy extensions in the future.
  21. Maintain Code Structure: Ensure that the code maintains a clear and logical structure. Group related functions together and use consistent naming conventions.
  22. Documentation of Tests: Ensure that any tests added or modified are well-documented, explaining the purpose of the tests and what functionality they are verifying.

As part of my research, I'm trying to understand how useful these comments are in real-world development. If you have a moment, I'd be super grateful if you could quickly reply to these two yes/no questions:

  1. Does this comment provide suggestions from a dimension you hadn’t considered?
    1. Do you find this comment helpful?

Thanks a lot for your time and feedback! And sorry again if this message is a bother.

ai moment

Copy link

@EldarKusdavletov EldarKusdavletov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M4ddCat
Copy link

M4ddCat commented Jun 26, 2025

Linux kernel need realy good practices like this.

Copy link

@M4ddCat M4ddCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than rust parts

@demndevel
Copy link

крутое

@Mtfl0n
Copy link

Mtfl0n commented Jul 9, 2025

только благодаря таким изменениям ядро будет процветать

@unixource
Copy link

изображение изображение

@amitabhakarmakar
Copy link

amitabhakarmakar commented Jul 15, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.