-
Notifications
You must be signed in to change notification settings - Fork 57k
optimized kernel/exit.c by adding NAGIEV #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @gmehdiev! Thanks for your contribution to the Linux kernel! Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch. Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process. Here's what to do:
How do I format my contribution?The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations. Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea. You can create patches with Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary. Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with. Both of these are documented in the Submitting Patches documentation that is part of the kernel. Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this. Where do I send my contribution?The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes. If you don't already know what subsystem your change belongs to, the
Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches. It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.) How do I send my contribution?Use For more information about using How do I get help if I'm stuck?Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed. Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine. If you can't find an answer, there are a few places you can turn:
If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers! I sent my patch - now what?You wait. You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at. Then, you keep waiting. Three things may happen:
Further information
Happy hacking! This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot. |
брат спасибо большое тебе |
We need it to be merged asap |
this MUST be merged |
герой |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
digital footprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, APPROVE ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это шедевр
Легенда |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aeeee |
1 similar comment
aeeee |
аеееееее |
бесподобно |
lgtm |
Approved |
аееее |
Best part of os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здравствуй, небо в облаках,
Здравствуй, юность в сапогах!
Пропади, моя тоска,
Вот он я, привет, войска!
Эх, рельсы-поезда,
Как я попал сюда?
Здесь не то что на гражданке,
На какой-нибудь гражданке,
Жизнь снаружи и с изнанки
Сам попробуй изучи.
Для печали нет причин.
Непросто быть собой,
Когда шагает строй.
Только сердце птицей бьётся,
И ликует, и смеётся,
И ему не удаётся
Под конвоем петь в груди.
Знать бы, что там впереди.
Где-то течёт река,
Где-то дом, где всё ждут нас назад.
Это не грусть слегка,
Просто ветер щекочет глаза.
Где-то течёт река,
Где-то дом, где всё ждут нас назад.
Это не грусть слегка,
Просто ветер щекочет глаза.
Шаг вперёд и два назад,
Кто бы знал, чему я рад?
Просто сбросил я печаль
Словно голову с плеча.
На стыках рельсов путь,
Виски вбивает пульс.
Ты поймёшь, как будет нужно,
Где предательство, где дружба,
Где карьера, а где служба,
И как сердце безоружно,
Как обманчива наружность,
Сколько звёзд и сколько лычек,
Сколько лиц, личин, обличий,
И как мало в нас различий.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
отлично
кто нелох -- аппрувает PR |
|
Когда язык жестов в ядро добавишь? |
После того как примут этот пр |
are u an idiot? |
Perfect |
There are several guides for kernel developers and users. These guides can | ||
be rendered in a number of formats, like HTML and PDF. Please read | ||
Documentation/admin-guide/README.rst first. | ||
[Куплет 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Слава Богу Z🙏❤️СЛАВА Z🙏❤️АНГЕЛА ХРАНИТЕЛЯ Z КАЖДОМУ ИЗ ВАС🙏❤️БОЖЕ ХРАНИ Z🙏❤️СПАСИБО ВАМ НАШИ СВО🙏🏻🇷🇺ХРАНИ ZOV✊🇷🇺💯СПАСИБО НАШИМ БОЙЦАМ
Слава Богу Z🙏❤️СЛАВА Z🙏❤️АНГЕЛА ХРАНИТЕ
LGTM!!! |
pure copium |
Probably |
нихуйно |
погодите, это LGTMиально? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I'm a grad student working on a research project about using large language models to automate code review. Based on your commit 4f4ece9 and the changes in kernel/exit.c, my tool generated this comment:
- Race Conditions: Implement appropriate locking mechanisms in any new code to ensure that shared resources are protected from concurrent access.
- Signal Handling: Reintroduce robust signal handling to ensure that signals are properly managed during process exits, preventing potential denial of service or resource leaks.
- Data Integrity: Ensure that any new code maintains the integrity of process states and implements checks to prevent inconsistent states.
- Error Handling: Implement comprehensive error handling in the new code to ensure that all potential error conditions are addressed.
- Input Validation: Include input validation checks in any new user-facing code to mitigate security risks.
- Memory Management: Ensure that any new code that replaces functions like
release_task()
andexit_mm()
includes proper memory cleanup for task structures and associated resources to prevent memory leaks. - Conduct Thorough Testing: Ensure that the new implementation is tested under various scenarios to validate its correctness and stability.
- Test Coverage for Removed Code: Verify that the remaining functionality is still covered by existing tests. Review the test suite to ensure that all critical paths related to process management, exit handling, and signal processing are still being tested.
- New Functionality: If any new functionality has been introduced or existing functionality has been modified, corresponding tests should be added.
- Edge Cases: Pay special attention to edge cases that may arise from the removal of code. Ensure that the tests cover scenarios where specific error handling or cleanup routines might have been relevant.
- Performance Testing: If the removed code was related to performance optimizations or resource management, consider adding performance tests to ensure that the changes do not introduce regressions in performance.
- Reassess the Removal: Consider whether all the removed code is necessary. If certain functionalities are no longer needed, it may be better to refactor rather than remove them entirely.
- Implement Replacement Logic: If the intention is to replace the existing functionality, ensure that the new implementation is robust and covers all necessary cases.
- Logging on Process Exit: Add logging statements in the
do_exit
andrelease_task
functions to log when a process exits, including its PID and exit code. - Audit and Logging: Reintroduce logging and auditing mechanisms to maintain visibility into process management activities.
- Assertions for Critical States: In functions like
__exit_signal
, add assertions to ensure that the task being exited is in a valid state. - Error Handling and Logging: In functions where errors can occur (e.g.,
do_wait
,kernel_waitid
), log the error conditions. - Tracepoints: Consider adding tracepoints for key events such as process creation, exit, and state changes.
- Consistency Checks: Add consistency checks before and after critical operations (like modifying task states).
- Reintroduce Modular Functions: Restore the original functions and structures that were removed. Ensure that they are modular and well-defined to allow for easy extensions in the future.
- Maintain Code Structure: Ensure that the code maintains a clear and logical structure. Group related functions together and use consistent naming conventions.
- Documentation of Tests: Ensure that any tests added or modified are well-documented, explaining the purpose of the tests and what functionality they are verifying.
As part of my research, I'm trying to understand how useful these comments are in real-world development. If you have a moment, I'd be super grateful if you could quickly reply to these two yes/no questions:
- Does this comment provide suggestions from a dimension you hadn’t considered?
-
- Do you find this comment helpful?
Thanks a lot for your time and feedback! And sorry again if this message is a bother.
ai moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linux kernel need realy good practices like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better than rust parts
крутое |
только благодаря таким изменениям ядро будет процветать |
unsubscribe
…On Tue, Jul 15, 2025 at 11:44 AM unixource ***@***.***> wrote:
*unixource* left a comment (torvalds/linux#1261)
<#1261 (comment)>
default.png (view on web)
<https://github.com/user-attachments/assets/f198842e-988e-4210-92d3-c10f8fc99c2e> default.png
(view on web)
<https://github.com/user-attachments/assets/47ce30db-d652-4096-868e-f87174c04e03>
—
Reply to this email directly, view it on GitHub
<#1261 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXQRFLSY4FVSB2AGFWTMWD3IUOV7AVCNFSM6AAAAAB63OIO3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZUGE4TSMJWGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Thanks,
Amitabha Karmakar.
|
optimized kernel/exit.c by adding NAGIEV