-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(sui): proper port parsing in voyager #4644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
// NOTE(aeryz): casting to u64 is very important, otherwise usize will become u32 in wasm32 and this will result in incorrect hash | ||
hasher.update(((key_bytes.len() + 1) as u64).to_le_bytes()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also add a test for the hashing
let consensus_state = client.consensus_states.borrow(height); | ||
|
||
let mut path = vector<u8>[0x03]; | ||
path.append(client.client_state.contract_address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also append [0x00]
for the commitment prefix in the contract
pub async fn parse_port(_: &SuiClient, port_id: &str) -> ModuleInfo { | ||
// original_address::module_name::store_address | ||
// TODO(aeryz): we can also choose to include store_name here | ||
pub async fn parse_port(graphql_url: &str, port_id: &str) -> ModuleInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love seeing "async" and "parse" on the same line
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
c91f06b
to
05db76e
Compare
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
No description provided.