Skip to content

feat(sui): proper port parsing in voyager #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Jun 2, 2025

No description provided.

Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 5:46am

// NOTE(aeryz): casting to u64 is very important, otherwise usize will become u32 in wasm32 and this will result in incorrect hash
hasher.update(((key_bytes.len() + 1) as u64).to_le_bytes());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add a test for the hashing

let consensus_state = client.consensus_states.borrow(height);

let mut path = vector<u8>[0x03];
path.append(client.client_state.contract_address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also append [0x00] for the commitment prefix in the contract

pub async fn parse_port(_: &SuiClient, port_id: &str) -> ModuleInfo {
// original_address::module_name::store_address
// TODO(aeryz): we can also choose to include store_name here
pub async fn parse_port(graphql_url: &str, port_id: &str) -> ModuleInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love seeing "async" and "parse" on the same line

aeryz added 25 commits July 7, 2025 11:54
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the sui-connopen-with-full-verification branch from c91f06b to 05db76e Compare July 7, 2025 11:03
aeryz added 2 commits July 9, 2025 22:10
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
aeryz added 5 commits July 10, 2025 17:33
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants