Skip to content

refactor: merge cosmos-sdk and cosmos-sdk-union state modules into unified module #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

DeVikingMark
Copy link

Summary

Consolidates two separate state modules (cosmos-sdk and cosmos-sdk-union) into a single unified module that supports both IBC Classic and IBC Union specifications.

Changes

  • Merged modules: Combined voyager/modules/state/cosmos-sdk and voyager/modules/state/cosmos-sdk-union into single module
  • Added specification switching: Automatic detection between IBC Classic/Union based on ibc_spec_id
  • Unified configuration: Single config supporting both specs with optional ibc_host_contract_address for Union
  • Removed duplication: Eliminated duplicate code and simplified architecture
  • Updated dependencies: Combined Cargo.toml with dependencies for both specifications

Technical Details

  • SupportedIbcSpec enum handles specification switching
  • Runtime detection from StateModuleInfo.ibc_spec_id
  • Backward compatible configuration
  • Single binary replaces two separate modules

Files Changed

  • voyager/modules/state/cosmos-sdk/src/main.rs - unified implementation
  • voyager/modules/state/cosmos-sdk/Cargo.toml - merged dependencies
  • Cargo.toml - removed cosmos-sdk-union from workspace
  • Deleted: voyager/modules/state/cosmos-sdk-union/ directory

Fixes #3526

@DeVikingMark DeVikingMark requested a review from benluelo as a code owner June 14, 2025 19:42
Copy link

vercel bot commented Jun 14, 2025

@DeVikingMark is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

@cor
Copy link
Contributor

cor commented Jun 14, 2025

Thanks for contributing! Can you please make the CI checks pass?

@DeVikingMark
Copy link
Author

@cor made some changes, I guess all the other ci's aren't related to my pr, isn't it?

@benluelo
Copy link
Contributor

benluelo commented Jul 1, 2025

this fundamentally does not work. the referenced issue is old has been made irrelevant due to several refactors in the voyager design.

@benluelo benluelo closed this Jul 1, 2025
@unionlabs unionlabs locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge cosmos sdk state modules
3 participants