fix: lark document i18n error #2671
Conversation
--bug=1053850 --user=王孝刚 [知识库]英文语言模式-添加飞书文档页面未国际化&提示的翻译错误 https://www.tapd.cn/57709429/s/1675482
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| appIdPlaceholder: 'Please enter APP ID', | ||
| appSecretPlaceholder: 'Please enter APP secret', | ||
| appIdPlaceholder: 'Please enter App ID', | ||
| appSecretPlaceholder: 'Please enter App secret', | ||
| verificationTokenPlaceholder: 'Please enter verification token', | ||
| urlInfo: | ||
| '-Events and callbacks - event configuration - configure the "request address" of the subscription method', |
There was a problem hiding this comment.
The code is correct and doesn't contain any irregularities or potential issues. The only change you made is to capitalize the word "App" in the appIdPlaceholder, which is a stylistic preference rather than functional. However, both original placeholders were already correctly formatted.
No optimization suggestions are necessary for this simple object definition in JavaScript.
| @@ -151,7 +151,7 @@ | |||
| :placeholder="$t('views.application.applicationAccess.larkSetting.appIdPlaceholder')" | |||
| /> | |||
| </el-form-item> | |||
| <el-form-item label="App Secret" prop="app_id" v-if="datasetForm.type === '2'"> | |||
| <el-form-item label="App Secret" prop="app_secret" v-if="datasetForm.type === '2'"> | |||
| <el-input | |||
| v-model="datasetForm.app_secret" | |||
| type="password" | |||
There was a problem hiding this comment.
The provided code has a few minor issues:
- The placeholder text "App ID Placeholder" in the
v-textdirective is incorrectly spelled as "larkSetting". - The attribute name used for binding to the
datasetForm.app_secretin the input field should match the property key in the data object.
Here are the corrected lines of code:
@@ -151,7 +151,7 @@
:placeholder="$t('views.application.applicationAccess.larkSetting.appIdPlaceholder')"
/>
</el-form-item>
- <el-form-item label="App Secret" prop="app_id" v-if="datasetForm.type === '2'">
+ <el-form-item label="App Secret" prop="app_secret" v-if="datasetForm.type === '2'">
<el-input
v-model="datasetForm.app_secret"
type="password"These changes ensure that the correct placeholders and form items are used throughout the component.
| @@ -3,6 +3,7 @@ export default { | |||
| createDataset: 'Create Knowledge', | |||
| general: 'General', | |||
| web: 'Web Site', | |||
| lark: 'Lark', | |||
| relatedApplications: 'Linked App', | |||
| document_count: 'docs', | |||
| relatedApp_count: 'linked apps', | |||
There was a problem hiding this comment.
The provided code is syntactically correct, free from grammatical errors, and does not contain significant optimization opportunities within its current structure. However, if you have additional context about how this code block will be used or if there are specific performance considerations related to locale handling or other areas, I can offer further feedback on those specifics.
fix: lark document i18n error --bug=1053850 --user=王孝刚 [知识库]英文语言模式-添加飞书文档页面未国际化&提示的翻译错误 https://www.tapd.cn/57709429/s/1675482