Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does upstream.Upstream is goroutine safe #403

Closed
Nyx2022 opened this issue Jul 16, 2024 · 1 comment
Closed

does upstream.Upstream is goroutine safe #403

Nyx2022 opened this issue Jul 16, 2024 · 1 comment
Labels
question Further information is requested

Comments

@Nyx2022
Copy link

Nyx2022 commented Jul 16, 2024

as the title, i wanna know if the upstream.Upstream is goroutine safe?
adguard pushed a commit that referenced this issue Jul 17, 2024
@EugeneOne1
Pull request 370: 402 Fix ID race
50640fb 
Updates #402.
Updates #403.

Squashed commit of the following:

commit 0cf20f1
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jul 16 18:17:59 2024 +0300

    upstream: fix cache race

commit da41431
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jul 16 17:53:28 2024 +0300

    upstream: decrease external timeout

commit f39f02e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jul 16 17:46:57 2024 +0300

    upstream: imp docs

commit e3d9d20
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jul 16 15:50:24 2024 +0300

    upstream: fix id race
@EugeneOne1 EugeneOne1 added the question Further information is requested label Jul 17, 2024
@EugeneOne1
Copy link
Member

@Nyx2022, helllo. Yes, the upstream.Upstream implementations are designed to be safe for concurrent use, in 50640fb we've updated the documentation of the interface to reflect the contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EugeneOne1 @Nyx2022