Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

units for timeout configs #1968

Closed
ukarim opened this issue Jul 23, 2024 · 2 comments
Closed

units for timeout configs #1968

ukarim opened this issue Jul 23, 2024 · 2 comments

Comments

@ukarim
Copy link

ukarim commented Jul 23, 2024

Hi!

It would be great to specify units for timeout values in the documentation

Dsl.config()
        .setReadTimeout(xxx)
        .setConnectTimeout(xxx)
        .setRequestTimeout(xxx)
@hyperxpro
Copy link
Member

Would you like to do a PR?

@ukarim
Copy link
Author

ukarim commented Jul 28, 2024

@hyperxpro It looks like this issue will be automatically resolved with next stable release. 3.x.x version uses java.time.Duration as method argument.
Thanks!

@ukarim ukarim closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukarim @hyperxpro