Move profiler source files into the tracer repository (DataDog#2404)

- Make sure the azure pipelines build the profiler from tracer repository instead of the profiler internal repo.
- AzOps and Gitlabs checks


Co-authored-by: chrisnas <chrisnas@users.noreply.github.com>

Author: gleocadie

.azure-pipelines/ultimate-pipeline.yml

@@ -65,6 +65,7 @@ pr:
       - tracer/build/_build/Build.GitHub.cs
       - tracer/build/_build/Build.Gitlab.cs
       - .azure-pipelines/noop-pipeline.yml
+      - profiler/
 
 schedules:
   - cron: "0 3 * * *"
@@ -85,7 +86,6 @@ variables:
   relativeArtifacts: /tracer/src/bin/artifacts
   ddTracerHome: $(System.DefaultWorkingDirectory)/tracer/src/bin/dd-tracer-home
   tracerHome: $(System.DefaultWorkingDirectory)/tracer/src/bin/windows-tracer-home
-  profilerSrcDirectory: $(System.DefaultWorkingDirectory)/../dd-continuous-profiler-dotnet
   profilerHome: $(System.DefaultWorkingDirectory)/profiler/bin/profiler-home # Important, put the profiler assets into the working directory so it can be saved across build stages more easily
   monitoringHome: $(System.DefaultWorkingDirectory)/shared/bin/monitoring-home
   artifacts: $(System.DefaultWorkingDirectory)/tracer/src/bin/artifacts
@@ -117,11 +117,6 @@ resources:
     env:
       DD_API_KEY: $(ddApiKey)
       DD_INSIDE_CI: true
-  repositories:
-  - repository: dd-continuous-profiler-dotnet
-    type: github
-    endpoint: DataDog
-    name: DataDog/dd-continuous-profiler-dotnet
 
 # Stages
 stages:
@@ -190,34 +185,6 @@ stages:
 
     - template: steps/install-latest-dotnet-sdk.yml
 
-    # workaround for "Unable move and reuse existing repository to required location."
-    # https://github.com/microsoft/azure-pipelines-yaml/issues/403
-    - powershell: |
-        New-Item -Path . -Name "dd-continuous-profiler-dotnet" -ItemType "directory"
-      displayName: "Create repository folder (workaround)"
-
-    - checkout: dd-continuous-profiler-dotnet
-      path: dd-continuous-profiler-dotnet
-
-    - powershell: |
-        New-Item -Path $(System.DefaultWorkingDirectory)\..\dd-trace-dotnet -ItemType SymbolicLink -Value $(System.DefaultWorkingDirectory)
-      displayName: Create symlink from $(System.DefaultWorkingDirectory)\..\dd-trace-dotnet to $(System.DefaultWorkingDirectory)
-
-    - powershell: |
-        Write-Host "Attempting to check out ref specified by GIT_PROFILER_REF: '$(GIT_PROFILER_REF)'"
-        git checkout $(GIT_PROFILER_REF)
-      workingDirectory: $(System.DefaultWorkingDirectory)\..\dd-continuous-profiler-dotnet
-      displayName: Checkout GIT_PROFILER_REF
-
-    - powershell: |
-        $sha = git rev-parse --short HEAD
-        Write-Host "SHA is $sha"
-        echo "##vso[task.setvariable variable=BetaMsiSuffix;isOutput=true]v$(Build.BuildId)-$sha"
-        Write-Host "BetaMsiSuffix set to v$(Build.BuildId)-$sha"
-      workingDirectory: $(System.DefaultWorkingDirectory)\..\dd-continuous-profiler-dotnet
-      displayName: Persist the commit sha for the dd-continuous-profiler repo (temporary)
-      name: SetMsiSuffix # because we're going to depend on the variable output, we need to name the step
-
     - script: tracer\build.cmd BuildProfilerHome
       displayName: Build profiler home
 

.gitlab-ci.yml

@@ -16,8 +16,6 @@ build:
   script:
     - if (Test-Path build-out) { remove-item -recurse -force build-out }
     - if (Test-Path artifacts) { remove-item -recurse -force artifacts }
-    - Write-Host "Attempting to clone profiler repo with GIT_PROFILER_REF=${GIT_PROFILER_REF}"
-    - git clone -b ${GIT_PROFILER_REF} https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/dd-continuous-profiler-dotnet.git
     - docker run --rm -m 4096M -v "$(Get-Location):c:\mnt" -e CI_JOB_ID=${CI_JOB_ID} -e WINDOWS_BUILDER=true -e AWS_NETWORKING=true -e SIGN_WINDOWS=true 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_1809_x64:$Env:DATADOG_AGENT_WINBUILDIMAGES c:\mnt\tracer\build\_build\gitlab.bat
     - mkdir artifacts
     - xcopy /e/s build-out\${CI_JOB_ID}\*.* artifacts
@@ -58,4 +56,4 @@ publish:
               $i++
               Start-Sleep -Milliseconds 100
           }
-      } while ($i -lt 3)
+      } while ($i -lt 3)

docs/README.md

@@ -4,7 +4,7 @@ This repository contains the sources for the client-side components of the Datad
 
 **[Datadog .NET Tracer](https://github.com/DataDog/dd-trace-dotnet/tree/master/tracer)**: A set of .NET libraries that let you trace any piece of your .NET code. It automatically instruments supported libraries out-of-the-box and also supports custom instrumentation to instrument your own code.
 
-**[Datadog .NET Continuous Profiler](https://github.com/DataDog/dd-trace-dotnet/tree/master/profiler)**: To be added.
+**[Datadog .NET Continuous Profiler](https://github.com/DataDog/dd-trace-dotnet/tree/master/profiler)**: Libraries that automatically profile your application.
 
 ## Downloads
 
@@ -29,4 +29,4 @@ Copyright (c) 2017 Datadog
 
 ## License
 
-See [license information](../LICENSE).
+See [license information](../LICENSE).

profiler/.clang-format

@@ -0,0 +1,47 @@
+---
+# Set ColumnLimit to 0, because the behavior is not the same
+# ex: splitting arguments on multiple lines.
+ColumnLimit: 0
+UseTab: Never
+IndentWidth: 4
+AccessModifierOffset: -4
+NamespaceIndentation: Inner
+
+BreakBeforeBraces: Custom
+BraceWrapping:
+  AfterNamespace: false
+  AfterEnum: true
+  AfterStruct: true
+  AfterClass: true
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  AfterControlStatement: true
+  AfterFunction: true
+  AfterUnion: true
+  BeforeElse: true
+  AfterCaseLabel: true
+  AfterExternBlock: true
+  BeforeCatch: true
+
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializers: AfterColon
+CompactNamespaces: false
+AlwaysBreakTemplateDeclarations: true
+BreakConstructorInitializersBeforeComma: true
+ConstructorInitializerAllOnOneLineOrOnePerLine: true
+AllowShortBlocksOnASingleLine: false
+AllowShortFunctionsOnASingleLine: false
+AllowShortIfStatementsOnASingleLine: true
+AllowShortLoopsOnASingleLine: true
+PointerAlignment: Left
+AlignConsecutiveAssignments: false
+AlignTrailingComments: true
+SpaceAfterCStyleCast: true
+CommentPragmas: '^ NO-FORMAT:'
+IndentCaseLabels: true
+IndentGotoLabels: true
+SpaceAfterCStyleCast: false
+
+# The following doesn't work pre clang-format version 13
+#BreakBeforeConceptDeclarations: true
+#EmptyLineBeforeAccessModifier: LogicalBlock

profiler/.clang-tidy

@@ -0,0 +1,5 @@
+---
+Checks:            '-*,readability-*,clang-analyzer-*,cppcoreguidelines-*'
+WarningsAsErrors:  ''
+HeaderFilterRegex: '.*'
+FormatStyle:       'file'

profiler/CMakeLists.txt

@@ -0,0 +1,99 @@
+cmake_minimum_required (VERSION 3.14)
+cmake_policy(SET CMP0015 NEW)
+
+# ******************************************************
+# Environment detection
+# ******************************************************
+
+# Detect operating system
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+    message(FATAL_ERROR "Windows builds are not supported using CMAKE. Please use Visual Studio")
+    SET(ISWINDOWS true)
+elseif (CMAKE_SYSTEM_NAME MATCHES "Linux")
+    message(STATUS "Preparing Linux build")
+    SET(ISLINUX true)
+elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+    message(FATAL_ERROR "MACOS builds are not supported yet.")
+    SET(ISMACOS true)
+endif()
+
+# Detect bitness of the build
+if (CMAKE_SIZEOF_VOID_P EQUAL 8)
+    message(STATUS "Setting compilation for 64bits processor")
+    SET(BIT64 true)
+endif()
+
+# Detect architecture
+if (CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64 OR CMAKE_SYSTEM_PROCESSOR STREQUAL amd64)
+    message(STATUS "Architecture is x64/AMD64")
+    SET(ISAMD64 true)
+elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL x86 OR CMAKE_SYSTEM_PROCESSOR STREQUAL i686)
+    message(STATUS "Architecture is x86")
+    SET(ISX86 true)
+elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64)
+    message(STATUS "Architecture is ARM64")
+    SET(ISARM64 true)
+elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL armv7l OR CMAKE_SYSTEM_PROCESSOR STREQUAL arm)
+    message(STATUS "Architecture is ARM")
+    SET(ISARM true)
+endif()
+
+# Out of source build directory
+SET(OUTPUT_BUILD_DIR ${CMAKE_SOURCE_DIR}/../_build)
+
+SET(DOTNET_TRACER_REPO_ROOT_PATH ${CMAKE_SOURCE_DIR}/../dd-trace-dotnet)
+
+if (BIT64)
+    SET(ARCH_POSTFIX "x64")
+else()
+    SET(ARCH_POSTFIX "x86")
+endif()
+
+if (DEFINED RUN_ANALYSIS AND NOT RUN_ANALYSIS EQUAL 0)
+    SET(CMAKE_EXPORT_COMPILE_COMMANDS 1)
+endif()
+
+# ******************************************************
+# Detect prerequisites
+# ******************************************************
+
+if (NOT EXISTS /usr/bin/clang)
+    message(FATAL_ERROR "CLANG is required to build the project")
+else()
+    message(STATUS "CLANG was found")
+endif()
+
+if (NOT EXISTS /usr/bin/clang++)
+    message(FATAL_ERROR "CLANG++ is required to build the project")
+else()
+    message(STATUS "CLANG++ was found")
+endif()
+
+if (NOT EXISTS /usr/bin/git)
+    message(FATAL_ERROR "GIT is required to build the project")
+else()
+    message(STATUS "GIT was found")
+endif()
+
+if (DEFINED RUN_ANALYSIS AND RUN_ANALYSIS EQUAL 1)
+    if (NOT EXISTS /usr/bin/clang-tidy)
+        message(FATAL_ERROR "clang-tidy is required to build the project")
+    else()
+        message(STATUS "clang-tidy was found")
+    endif()
+endif()
+
+# ******************************************************
+# Output folders
+# ******************************************************
+
+# Set output folders
+SET(OUTPUT_TMP_DIR ${CMAKE_BINARY_DIR}/tmp.${CMAKE_SYSTEM_NAME}_${CMAKE_SYSTEM_PROCESSOR})
+SET(OUTPUT_DEPS_DIR ${CMAKE_BINARY_DIR}/deps)
+FILE(MAKE_DIRECTORY ${OUTPUT_DEPS_DIR})
+FILE(MAKE_DIRECTORY ${OUTPUT_TMP_DIR})
+
+add_subdirectory(src/ProfilerEngine/Datadog.Profiler.Native.Linux)
+add_subdirectory(src/ProfilerEngine/Datadog.Linux.ApiWrapper)
+enable_testing()
+add_subdirectory(test)