Skip to content

Add spectrograph support for SteelSeries Apex M800 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

saltybot
Copy link
Contributor

This code adds spectrograph support for the SteelSeries Apex M800 keyboard

@CalcProgrammer1
Copy link
Owner

Nice pull request, code looks clean and easy to merge! One thing I want to verify before I merge it in is that it properly returns FALSE and stops executing the thread if the Apex M800 is not detected. Thanks for adding this!

@CalcProgrammer1
Copy link
Owner

Build was clean, didn't affect operation of existing devices. Consider it merged!

@saltybot
Copy link
Contributor Author

Great! Thanks!

@CalcProgrammer1
Copy link
Owner

Do you know what keyboard layout you used to implent this? When doing the protocol from scratch you need to account for other region's keys. Finding those out is usually trial and error after you find someone to test who has a different region keyboard. A reddit user tested v2.01 and said two keys were not lighting on his UK layout keyboard. I'd like to figure out what the ID of those keys are to support that layout.

@saltybot
Copy link
Contributor Author

It was a US layout M800. I should be able to add support for UK layout.

@CalcProgrammer1
Copy link
Owner

Great! One other change that I was going to make tonight is to start at Y=2 rather than Y=0. The first two rows are reserved, row 0 is for the linear bar graph visualizer used on LED strip style devices and row 1 is for single color mode devices like mouse logos and devices with only one RGB LED. The Fn row was showing the horizontal bar graph which is not supposed to happen.

@saltybot
Copy link
Contributor Author

I just created a new pull request for the UK layout, #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants