Skip to content

Update RazerChromaLinux.cpp #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update RazerChromaLinux.cpp #73

wants to merge 2 commits into from

Conversation

rsandoz
Copy link
Contributor

@rsandoz rsandoz commented Jan 9, 2017

Added support for Razer Blade Pro and Death Adder Elite. Death Adder Elite does not work. It has two LEDs (logo and scrollwheel) just like your Death Adder Chroma and Naga Chroma. However examining around line 346 where the devices listed: logo_led_rgb, logo_led_effect, scroll_led_rgb, scroll_led_effect are different from my local setup which looks as follows:
rsandoz-Blade-Pro:/sys/bus/hid/drivers/razermouse/0003:1532:005C.0001# ls -la
total 0
drwxr-xr-x 5 root plugdev 0 Jan 8 16:48 .
drwxr-xr-x 5 root root 0 Jan 8 17:05 ..
-r--r--r-- 1 root plugdev 4096 Jan 8 16:48 country
-rw-rw---- 1 root plugdev 4096 Jan 8 16:48 device_mode
-r--r----- 1 root plugdev 4096 Jan 8 16:48 device_serial
-r--r----- 1 root plugdev 4096 Jan 8 16:48 device_type
-rw-rw---- 1 root plugdev 4096 Jan 8 16:48 dpi
lrwxrwxrwx 1 root plugdev 0 Jan 8 16:48 driver -> ../../../../../../../bus/hid/drivers/razermouse
-r--r----- 1 root plugdev 4096 Jan 8 16:48 firmware_version
drwxr-xr-x 3 root plugdev 0 Jan 8 16:48 hidraw
drwxr-xr-x 3 root plugdev 0 Jan 8 16:48 input
-rw-rw---- 1 root plugdev 4096 Jan 8 16:48 logo_led_brightness
--w--w---- 1 root plugdev 4096 Jan 8 16:48 logo_matrix_effect_breath
--w--w---- 1 root plugdev 4096 Jan 8 16:55 logo_matrix_effect_none
--w--w---- 1 root plugdev 4096 Jan 8 16:48 logo_matrix_effect_reactive
--w--w---- 1 root plugdev 4096 Jan 8 16:48 logo_matrix_effect_spectrum
--w--w---- 1 root plugdev 4096 Jan 8 16:56 logo_matrix_effect_static
-r--r--r-- 1 root plugdev 4096 Jan 8 16:48 modalias
-rw-rw---- 1 root plugdev 4096 Jan 8 16:48 poll_rate
drwxr-xr-x 2 root plugdev 0 Jan 8 16:48 power
-r--r--r-- 1 root plugdev 4096 Jan 8 16:48 report_descriptor
-rw-rw---- 1 root plugdev 4096 Jan 8 16:48 scroll_led_brightness
--w--w---- 1 root plugdev 4096 Jan 8 16:48 scroll_matrix_effect_breath
--w--w---- 1 root plugdev 4096 Jan 8 16:55 scroll_matrix_effect_none
--w--w---- 1 root plugdev 4096 Jan 8 16:48 scroll_matrix_effect_reactive
--w--w---- 1 root plugdev 4096 Jan 8 16:48 scroll_matrix_effect_spectrum
--w--w---- 1 root plugdev 4096 Jan 8 16:48 scroll_matrix_effect_static
lrwxrwxrwx 1 root plugdev 0 Jan 8 16:48 subsystem -> ../../../../../../../bus/hid
--w--w---- 1 root plugdev 4096 Jan 8 16:48 test
-rw-r--r-- 1 root plugdev 4096 Jan 8 16:48 uevent
-r--r----- 1 root plugdev 4096 Jan 8 16:48 version

@CalcProgrammer1
Copy link
Owner

CalcProgrammer1 commented Jan 9, 2017

Please make a BladeProXIndex[25] and BladeProYIndex[6] and duplicate the Blade SetupKeyboardGrid line with it. If you do what you did, you screw up the scaling on the Blade laptops that actually do only have 16 columns. These two laptops have different column counts and should be treated separately.

Create separate BladeProXIndex and BladeProYIndex arrays and update dependent code.
@rsandoz
Copy link
Contributor Author

rsandoz commented Jan 9, 2017

Done. Will test later on today (in Windows world now). I am kind of new to git (the contribution part). I just edited my copy of the RazerLinuxChroma.cpp. Do I need to take any other actions so you get my changes?

@CalcProgrammer1
Copy link
Owner

Looks good, I will merge it tonight.

@CalcProgrammer1
Copy link
Owner

Cherry picked your commits onto master and tested on my Blade Stealth. No interference with existing functionality so it's good to go. Closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants