Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: D-K-E/pyside-opengl-tutorials
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: D-K-E/pyside-opengl-tutorials
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 32 files changed
  • 1 contributor

Commits on Aug 30, 2019

  1. Copy the full SHA
    ca86395 View commit details

Commits on Aug 31, 2019

  1. Started to lights handling

    Lights handling is significanlty more difficult than the other
    tutorials since I introduce a lot of things at the same time.
    
    Now the application has a light source helper class.
    Which does not seem to generate any errors but is not working.
    I am not setting good uniform values to good places I guess
    Or there is some kind of logical mistake in handling.
    Light sources.
    D-K-E committed Aug 31, 2019
    Copy the full SHA
    2173df3 View commit details
  2. formating

    D-K-E committed Aug 31, 2019
    Copy the full SHA
    a555cf5 View commit details

Commits on Sep 1, 2019

  1. Shader version change gllights advancements

    Shader versions are now #version 330 core
    Gllights had a moment of work but when I use the
    formula from Foley JD 1996, it does not work
    for some reason.
    Shaders requires a little more work
    D-K-E committed Sep 1, 2019
    Copy the full SHA
    562a3cc View commit details
  2. Lighting directions are all wrong but works

    Some unknown reason directions are all wrong.
    When the light object goes behind the object
    it is the front side that is lit.
    It is either shader or the code is at fault here.
    But at least the object is lit.
    The ambient light can be parametrized to use coefficients
    as well for better control.
    Diffuse light and the specular light can be used in
    the same manner as well.
    D-K-E committed Sep 1, 2019
    Copy the full SHA
    b3ed591 View commit details

Commits on Sep 2, 2019

  1. Still lights are not working

    Lights are still not working. I think I am going to implement
    Learn OpenGL example.
    D-K-E committed Sep 2, 2019
    Copy the full SHA
    9a38ffb View commit details
  2. Copy the full SHA
    ab32159 View commit details
  3. There is a problem with attenuation values

    There is a problem with attenuation values they simply cancel out
    the fragment value.
    They either set it to white entirely. And it does not matter the
    specular or diffuse color. They simply cancel it.
    There is probably a problem with their correct setting.
    The good news is that the shaders are not at fault here.
    D-K-E committed Sep 2, 2019
    Copy the full SHA
    ba4ec95 View commit details

Commits on Sep 3, 2019

  1. Started multi lights

    Lights tutorial should be written the core functions for multi lights are
    done, they don't work now. I am not sure why. But the wiring with the
    front end should not be too difficult in any case.
    D-K-E committed Sep 3, 2019
    Copy the full SHA
    ea1dfac View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff master...dev