-
Notifications
You must be signed in to change notification settings - Fork 9
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: D-K-E/pyside-opengl-tutorials
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: D-K-E/pyside-opengl-tutorials
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 32 files changed
- 1 contributor
Commits on Aug 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ca86395 - Browse repository at this point
Copy the full SHA ca86395View commit details
Commits on Aug 31, 2019
-
Lights handling is significanlty more difficult than the other tutorials since I introduce a lot of things at the same time. Now the application has a light source helper class. Which does not seem to generate any errors but is not working. I am not setting good uniform values to good places I guess Or there is some kind of logical mistake in handling. Light sources.
Configuration menu - View commit details
-
Copy full SHA for 2173df3 - Browse repository at this point
Copy the full SHA 2173df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a555cf5 - Browse repository at this point
Copy the full SHA a555cf5View commit details
Commits on Sep 1, 2019
-
Shader version change gllights advancements
Shader versions are now #version 330 core Gllights had a moment of work but when I use the formula from Foley JD 1996, it does not work for some reason. Shaders requires a little more work
Configuration menu - View commit details
-
Copy full SHA for 562a3cc - Browse repository at this point
Copy the full SHA 562a3ccView commit details -
Lighting directions are all wrong but works
Some unknown reason directions are all wrong. When the light object goes behind the object it is the front side that is lit. It is either shader or the code is at fault here. But at least the object is lit. The ambient light can be parametrized to use coefficients as well for better control. Diffuse light and the specular light can be used in the same manner as well.
Configuration menu - View commit details
-
Copy full SHA for b3ed591 - Browse repository at this point
Copy the full SHA b3ed591View commit details
Commits on Sep 2, 2019
-
Lights are still not working. I think I am going to implement Learn OpenGL example.
Configuration menu - View commit details
-
Copy full SHA for 9a38ffb - Browse repository at this point
Copy the full SHA 9a38ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab32159 - Browse repository at this point
Copy the full SHA ab32159View commit details -
There is a problem with attenuation values
There is a problem with attenuation values they simply cancel out the fragment value. They either set it to white entirely. And it does not matter the specular or diffuse color. They simply cancel it. There is probably a problem with their correct setting. The good news is that the shaders are not at fault here.
Configuration menu - View commit details
-
Copy full SHA for ba4ec95 - Browse repository at this point
Copy the full SHA ba4ec95View commit details
Commits on Sep 3, 2019
-
Lights tutorial should be written the core functions for multi lights are done, they don't work now. I am not sure why. But the wiring with the front end should not be too difficult in any case.
Configuration menu - View commit details
-
Copy full SHA for ea1dfac - Browse repository at this point
Copy the full SHA ea1dfacView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...dev