Skip to content

Add new guide for cleaning up monitor clutter #30255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Jul 2, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

@estherk15 estherk15 requested a review from a team as a code owner July 2, 2025 16:25
@estherk15 estherk15 added the WORK IN PROGRESS No review needed, it's a wip ;) label Jul 2, 2025
@github-actions github-actions bot added the Guide Content impacting a guide label Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Jul 2, 2025
@estherk15 estherk15 requested a review from khangtruong July 2, 2025 17:12
@estherk15 estherk15 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jul 7, 2025
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khangtruong, I left some minor feedback that will clean this up a bit. Please request a re-review when you are ready! Also, a tiny bit out of scope for this, but can you please make the following corrections?

  • Line 57: remove extra space in the ## Monitor templates heading
  • Line 59: add an Oxford comma between "metrics" and "and"

thank you!

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@estherk15 estherk15 requested a review from rtrieu July 11, 2025 19:34
@estherk15 estherk15 merged commit 111648e into master Jul 11, 2025
16 checks passed
@estherk15 estherk15 deleted the esther/docs-11237-monitors-managing-resources-guide branch July 11, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants