Update Simplicity integeration

[roconnor-blockstream]

This Simplicity update has

• renamed a few types
• moved some files around
• added a minCost parameter, currently set to 0
• added a new error code

[apoelstra]

Where can I find Simplicity commit c68063f9ef ? The previous commit is the C-master branch on the Simplicity Github repo.

[roconnor-blockstream]

Sorry, I forgot to push. You can find C-master now at https://github.com/BlockstreamResearch/simplicity/tree/C-master

[roconnor-blockstream]

The fuzzer is failling due to unsigned integer overflow. It's one of those annoying things were overflow is well defined. In this case we are overflowing the amount fields, but that cannot overflow in valid transactions, and even if it were valid, it is the defined behaviour we have.

I suppose we ought to push a fix for the fuzzer before merging this PR?

[apoelstra]

Yeah, can you add a new sanitizer suppression for the fuzzer? I think there are already a bunch for Simplicity. They are in test/sanitizer_suppressions/ubsan.

[roconnor-blockstream]

Turns out the ubsan rule was there, but because this PR moves some source files around, the reference in sanitizer_suppressions is not longer correct.

So I need to fix this in this PR.

[roconnor-blockstream]

c1 : fatal error C1083: Cannot open source file: '....\src\simplicity\cmr.c': No such file or directory [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\libelementssimplicity\libelementssimplicity.vcxproj]

MSVC build needs more work

[roconnor-blockstream]

C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(1091,5): warning MSB8027: Two or more files with the name of jets.c will produce outputs to the same location. This can lead to an incorrect build result. The files involved are ....\src\simplicity\jets.c, ....\src\simplicity\elements\jets.c. [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\libelementssimplicity\libelementssimplicity.vcxproj]

I forgot that I'm not allowed to use the same C file name in different subdirectories. :/

[roconnor-blockstream]

Fixed

[delta1]

ACK 0a0a69f

Ran tests locally

[apoelstra]

ACK 0a0a69f

Confirmed that the Simplicity branch is updated correctly to the C-master branch; that the C-master branch matches master's C/ directory; that all functional tests and unit tests pass; and that I could build and run the fuzz tests (on completion Nix seemed to deadlock but I believe this is because I was running multiple nix-builds in parallel, not because of our tests).

Sorry for the long delay.