Skip to content

Reduce redundancy in the span format #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Reduce redundancy in the span format #61

merged 3 commits into from
May 7, 2025

Conversation

aryanjassal
Copy link
Member

Description

Cleans up the span format by using consistent event types (start/stop) and converts the span ID into base32hex to align with node IDs in Polykey.

Issues Fixed

Tasks

  • 1. Change ID format from base64 to base32hex
  • 2. Change types from start/end to start/stop
  • 3. Reduce redundancy of information in span format

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@linear Linear
Copy link

linear bot commented May 6, 2025

ENG-612

@aryanjassal aryanjassal self-assigned this May 6, 2025
@aryanjassal
Copy link
Member Author

All the proposed changes from #15 and #60 have been introduced in this PR. Merging.

@aryanjassal aryanjassal merged commit ef677fc into staging May 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aryanjassal aryanjassal

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Span format
1 participant
@aryanjassal