Skip to content

Reflect requirement for JAVA_HOME with temurin17 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

nuviedo
Copy link
Contributor

@nuviedo nuviedo commented Oct 23, 2024

When I follow the Windows setup tutorial for Android on a clean install, using OpenJDK 17 through chocolatey as suggested, doctor fails to detect the location then advises to follow the tutorial or set the JAVA_HOME environment variable.

For context, the error message is as follows:

Error executing command 'javac'. Make sure you have installed The Java Development Kit (JDK) and set JAVA_HOME environment variable.
 You will not be able to build your projects for Android.
To be able to build for Android, verify that you have installed The Java Development Kit (JDK) and configured it according to system requirements as
 described in https://docs.nativescript.org/setup

The tutorial only instructs to add the binaries to PATH and can lead to confusion for new users, as JAVA_HOME expects the parent directory instead. After correctly setting the variable, the rest of the setup completes successfully.

I have updated the documentation to reflect this requirement.

Copy link
Contributor

@NathanWalker NathanWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@NathanWalker NathanWalker merged commit f940e18 into NativeScript:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants